Skip to content

createbundle function error in check maxbundlesize #261

Description

@BoLu1225

Should use "bundle.length >= maxBundleSizeNum" instead of "entries.length >= maxBundleSizeNum"

for (const entry of entries) {
const maxBundleSizeNum = BigNumber.from(maxBundleSize ?? 0).toNumber()
if (maxBundleSizeNum !== 0 && entries.length >= maxBundleSizeNum) {
debug('exiting after maxBundleSize is reached', maxBundleSize, entries.length)
break
}

createbundle function checks bundle size by using "entries.length >= maxBundleSizeNum", however, entries.length is a fixed value and represents the number of userops in mempool, shouldn't it be "bundle.length >= maxBundleSizeNum"?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions