Should use "bundle.length >= maxBundleSizeNum" instead of "entries.length >= maxBundleSizeNum"
|
for (const entry of entries) { |
|
const maxBundleSizeNum = BigNumber.from(maxBundleSize ?? 0).toNumber() |
|
if (maxBundleSizeNum !== 0 && entries.length >= maxBundleSizeNum) { |
|
debug('exiting after maxBundleSize is reached', maxBundleSize, entries.length) |
|
break |
|
} |
createbundle function checks bundle size by using "entries.length >= maxBundleSizeNum", however, entries.length is a fixed value and represents the number of userops in mempool, shouldn't it be "bundle.length >= maxBundleSizeNum"?
Should use "bundle.length >= maxBundleSizeNum" instead of "entries.length >= maxBundleSizeNum"
bundler/packages/bundler/src/modules/BundleManager.ts
Lines 336 to 341 in c70c909
createbundle function checks bundle size by using "entries.length >= maxBundleSizeNum", however, entries.length is a fixed value and represents the number of userops in mempool, shouldn't it be "bundle.length >= maxBundleSizeNum"?