Build failing on Linux

[angelcaru]

Error message:

warning: unused import: `std::path::Path`
 --> crates/dobby-sys/build.rs:3:5
  |
3 | use std::path::Path;
  |     ^^^^^^^^^^^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default

warning: `dobby-sys` (build script) generated 1 warning
   Compiling dobby-sys v0.1.0 (/home/angel/projects/other-peoples/lovely-injector/crates/dobby-sys)
warning: unused imports: `pattern` and `regex`
  --> crates/lovely-core/src/lib.rs:18:13
   |
18 | use patch::{pattern, regex, Patch, PatchFile, Priority};
   |             ^^^^^^^  ^^^^^
   |
   = note: `#[warn(unused_imports)]` on by default

warning: `lovely-core` (lib) generated 1 warning (run `cargo fix --lib -p lovely-core` to apply 1 suggestion)
error: failed to run custom build command for `dobby-sys v0.1.0 (/home/angel/projects/other-peoples/lovely-injector/crates/dobby-sys)`

Caused by:
  process didn't exit successfully: `/home/angel/projects/other-peoples/lovely-injector/target/debug/build/dobby-sys-51279cfcc340e44d/build-script-build` (exit status: 101)
  --- stdout
  CMAKE_TOOLCHAIN_FILE_x86_64-unknown-linux-gnu = None
  CMAKE_TOOLCHAIN_FILE_x86_64_unknown_linux_gnu = None
  HOST_CMAKE_TOOLCHAIN_FILE = None
  CMAKE_TOOLCHAIN_FILE = None
  CMAKE_GENERATOR_x86_64-unknown-linux-gnu = None
  CMAKE_GENERATOR_x86_64_unknown_linux_gnu = None
  HOST_CMAKE_GENERATOR = None
  CMAKE_GENERATOR = None
  CMAKE_PREFIX_PATH_x86_64-unknown-linux-gnu = None
  CMAKE_PREFIX_PATH_x86_64_unknown_linux_gnu = None
  HOST_CMAKE_PREFIX_PATH = None
  CMAKE_PREFIX_PATH = None
  CMAKE_x86_64-unknown-linux-gnu = None
  CMAKE_x86_64_unknown_linux_gnu = None
  HOST_CMAKE = None
  CMAKE = None
  running: cd "/home/angel/projects/other-peoples/lovely-injector/target/debug/build/dobby-sys-de7aca0b55c7b096/out/build" && CMAKE_PREFIX_PATH="" LC_ALL="C" "cmake" "/home/angel/projects/other-peoples/lovely-injector/crates/dobby-sys/dobby" "-DCMAKE_OSX_DEPLOYMENT_TARGET=11.0" "-DCMAKE_INSTALL_PREFIX=/home/angel/projects/other-peoples/lovely-injector/target/debug/build/dobby-sys-de7aca0b55c7b096/out" "-DCMAKE_C_FLAGS= -ffunction-sections -fdata-sections -fPIC -m64" "-DCMAKE_C_COMPILER=/usr/bin/cc" "-DCMAKE_CXX_FLAGS= -ffunction-sections -fdata-sections -fPIC -m64" "-DCMAKE_CXX_COMPILER=/usr/bin/c++" "-DCMAKE_ASM_FLAGS= -ffunction-sections -fdata-sections -fPIC -m64" "-DCMAKE_ASM_COMPILER=/usr/bin/cc" "-DCMAKE_BUILD_TYPE=Debug"
  -- 
  -- ********* build environment check ***********
  -- 	Compiler: 	 GNU
  -- 	Processor:	 x86_64
  -- 	System:   	 Linux
  -- ***************************************
  -- 
  -- CMAKE_C_COMPILER: /usr/bin/cc
  -- CMAKE_CXX_COMPILER: /usr/bin/c++
  -- CMAKE_C_FLAGS:  -ffunction-sections -fdata-sections -fPIC -m64 -fvisibility=hidden -fPIC -fno-stack-check -fno-stack-protector -fno-exceptions -fno-rtti -fno-common -fno-zero-initialized-in-bss -fPIC
  -- CMAKE_CXX_FLAGS:  -ffunction-sections -fdata-sections -fPIC -m64 -fvisibility=hidden -fPIC -fno-stack-check -fno-stack-protector -fno-exceptions -fno-rtti -fno-common -fno-zero-initialized-in-bss -fPIC  -ffunction-sections -fdata-sections -fPIC -m64
  -- CMAKE_SHARED_LINKER_FLAGS: 
  -- [Dobby] CMAKE_BUILD_TYPE: Debug
  -- [Dobby] DOBBY_DEBUG: ON
  -- [Dobby] NearBranch: ON
  -- [Dobby] FullFloatingPointRegisterPack: OFF
  -- [Dobby] Plugin.SymbolResolver: ON
  -- [Dobby] Plugin.ImportTableReplace: OFF
  -- [Dobby] Plugin.Android.BionicLinkerUtil: OFF
  -- [Dobby] DOBBY_BUILD_EXAMPLE: OFF
  -- [Dobby] DOBBY_BUILD_TEST: OFF
  -- [Dobby] DOBBY_BUILD_KERNEL_MODE: OFF
  -- [Dobby] Private.Obfuscation: OFF
  -- [Dobby] Dobby-20250415-5dfc854
  -- Configuring done
  -- Generating done
  -- Build files have been written to: /home/angel/projects/other-peoples/lovely-injector/target/debug/build/dobby-sys-de7aca0b55c7b096/out/build
  running: cd "/home/angel/projects/other-peoples/lovely-injector/target/debug/build/dobby-sys-de7aca0b55c7b096/out/build" && LC_ALL="C" MAKEFLAGS="-j --jobserver-fds=8,9 --jobserver-auth=8,9" "cmake" "--build" "/home/angel/projects/other-peoples/lovely-injector/target/debug/build/dobby-sys-de7aca0b55c7b096/out/build" "--target" "dobby_static" "--config" "Debug"
  [  4%] Building CXX object CMakeFiles/dobby_static.dir/source/InstructionRelocation/arm64/InstructionRelocationARM64.cc.o
  [  4%] Building CXX object CMakeFiles/dobby_static.dir/source/core/assembler/assembler-x64.cc.o
  [  7%] Building CXX object CMakeFiles/dobby_static.dir/source/InstructionRelocation/x86/InstructionRelocationX86.cc.o
  [  9%] Building CXX object CMakeFiles/dobby_static.dir/source/InstructionRelocation/x86/InstructionRelocationX86Shared.cc.o
  [ 12%] Building CXX object CMakeFiles/dobby_static.dir/source/InstructionRelocation/x64/InstructionRelocationX64.cc.o
  [ 14%] Building C object CMakeFiles/dobby_static.dir/source/InstructionRelocation/x86/x86_insn_decode/x86_insn_decode.c.o

  --- stderr
  In file included from /home/angel/projects/other-peoples/lovely-injector/crates/dobby-sys/dobby/./common/os_arch_features.h:5,
                   from /home/angel/projects/other-peoples/lovely-injector/crates/dobby-sys/dobby/./source/dobby/common.h:12,
                   from /home/angel/projects/other-peoples/lovely-injector/crates/dobby-sys/dobby/./source/core/assembler/assembler-x64.h:3,
                   from /home/angel/projects/other-peoples/lovely-injector/crates/dobby-sys/dobby/source/core/assembler/assembler-x64.cc:4:
  /home/angel/projects/other-peoples/lovely-injector/crates/dobby-sys/dobby/./common/pac_kit.h:7:41: error: missing binary operator before token "("
      7 | #if defined(__arm64e__) || __has_feature(ptrauth_calls)
        |                                         ^
  /home/angel/projects/other-peoples/lovely-injector/crates/dobby-sys/dobby/./common/pac_kit.h:15:18: error: missing binary operator before token "("
     15 | #if __has_feature(ptrauth_calls) || __arm64e__
        |                  ^
  /home/angel/projects/other-peoples/lovely-injector/crates/dobby-sys/dobby/./common/pac_kit.h:30:18: error: missing binary operator before token "("
     30 | #if __has_feature(ptrauth_calls) || __arm64e__
        |                  ^
  /home/angel/projects/other-peoples/lovely-injector/crates/dobby-sys/dobby/./common/os_arch_features.h:9:41: error: missing binary operator before token "("
      9 | #if defined(__arm64e__) && __has_feature(ptrauth_calls)
        |                                         ^
  cc1: warning: command-line option '-fno-rtti' is valid for C++/D/ObjC++ but not for C
  In file included from /home/angel/projects/other-peoples/lovely-injector/crates/dobby-sys/dobby/./common/os_arch_features.h:5,
                   from /home/angel/projects/other-peoples/lovely-injector/crates/dobby-sys/dobby/./source/dobby/common.h:12,
                   from /home/angel/projects/other-peoples/lovely-injector/crates/dobby-sys/dobby/./source/dobby/dobby_internal.h:3,
                   from /home/angel/projects/other-peoples/lovely-injector/crates/dobby-sys/dobby/source/InstructionRelocation/x86/InstructionRelocationX86Shared.cc:5:
  /home/angel/projects/other-peoples/lovely-injector/crates/dobby-sys/dobby/./common/pac_kit.h:7:41: error: missing binary operator before token "("
      7 | #if defined(__arm64e__) || __has_feature(ptrauth_calls)
        |                                         ^
  /home/angel/projects/other-peoples/lovely-injector/crates/dobby-sys/dobby/./common/pac_kit.h:15:18: error: missing binary operator before token "("
     15 | #if __has_feature(ptrauth_calls) || __arm64e__
        |                  ^
  /home/angel/projects/other-peoples/lovely-injector/crates/dobby-sys/dobby/./common/pac_kit.h:30:18: error: missing binary operator before token "("
     30 | #if __has_feature(ptrauth_calls) || __arm64e__
        |                  ^
  /home/angel/projects/other-peoples/lovely-injector/crates/dobby-sys/dobby/./common/os_arch_features.h:9:41: error: missing binary operator before token "("
      9 | #if defined(__arm64e__) && __has_feature(ptrauth_calls)
        |                                         ^
  In file included from /home/angel/projects/other-peoples/lovely-injector/crates/dobby-sys/dobby/./common/os_arch_features.h:5,
                   from /home/angel/projects/other-peoples/lovely-injector/crates/dobby-sys/dobby/./source/dobby/common.h:12,
                   from /home/angel/projects/other-peoples/lovely-injector/crates/dobby-sys/dobby/./source/dobby/dobby_internal.h:3,
                   from /home/angel/projects/other-peoples/lovely-injector/crates/dobby-sys/dobby/source/InstructionRelocation/x64/InstructionRelocationX64.cc:5:
  /home/angel/projects/other-peoples/lovely-injector/crates/dobby-sys/dobby/./common/pac_kit.h:7:41: error: missing binary operator before token "("
      7 | #if defined(__arm64e__) || __has_feature(ptrauth_calls)
        |                                         ^
  /home/angel/projects/other-peoples/lovely-injector/crates/dobby-sys/dobby/./common/pac_kit.h:15:18: error: missing binary operator before token "("
     15 | #if __has_feature(ptrauth_calls) || __arm64e__
        |                  ^
  /home/angel/projects/other-peoples/lovely-injector/crates/dobby-sys/dobby/./common/pac_kit.h:30:18: error: missing binary operator before token "("
     30 | #if __has_feature(ptrauth_calls) || __arm64e__
        |                  ^
  /home/angel/projects/other-peoples/lovely-injector/crates/dobby-sys/dobby/./common/os_arch_features.h:9:41: error: missing binary operator before token "("
      9 | #if defined(__arm64e__) && __has_feature(ptrauth_calls)
        |                                         ^
  /home/angel/projects/other-peoples/lovely-injector/crates/dobby-sys/dobby/source/InstructionRelocation/x64/InstructionRelocationX64.cc:22: warning: "_" redefined
     22 | #define _ turbo_assembler_.
        | 
  In file included from /home/angel/projects/other-peoples/lovely-injector/crates/dobby-sys/dobby/source/InstructionRelocation/x64/InstructionRelocationX64.cc:12:
  /home/angel/projects/other-peoples/lovely-injector/crates/dobby-sys/dobby/./source/core/codegen/codegen-x64.h:16: note: this is the location of the previous definition
     16 | #define _ turbo_assembler_->
        | 
  /home/angel/projects/other-peoples/lovely-injector/crates/dobby-sys/dobby/source/InstructionRelocation/x64/InstructionRelocationX64.cc:23: warning: "__" redefined
     23 | #define __ turbo_assembler_.code_buffer()->
        | 
  /home/angel/projects/other-peoples/lovely-injector/crates/dobby-sys/dobby/./source/core/codegen/codegen-x64.h:17: note: this is the location of the previous definition
     17 | #define __ turbo_assembler_->code_buffer_.
        | 
  In file included from /home/angel/projects/other-peoples/lovely-injector/crates/dobby-sys/dobby/./source/dobby/common.h:7:
  /home/angel/projects/other-peoples/lovely-injector/crates/dobby-sys/dobby/./source/dobby/utility_macro.h:60:16: warning: attributes are not permitted in this position [-Wattributes]
     60 | #define PUBLIC __attribute__((visibility("default")))
        |                ^~~~~~~~~~~~~
  /home/angel/projects/other-peoples/lovely-injector/crates/dobby-sys/dobby/./source/InterceptRouting/NearBranchTrampoline/NearBranchTrampoline.h:11:1: note: in expansion of macro 'PUBLIC'
     11 | PUBLIC extern "C" inline void dobby_set_near_trampoline(bool enable) {
        | ^~~~~~
  In file included from /home/angel/projects/other-peoples/lovely-injector/crates/dobby-sys/dobby/./source/InterceptRouting/InterceptRouting.h:8,
                   from /home/angel/projects/other-peoples/lovely-injector/crates/dobby-sys/dobby/./source/dobby/dobby_internal.h:13:
  /home/angel/projects/other-peoples/lovely-injector/crates/dobby-sys/dobby/./source/InterceptRouting/NearBranchTrampoline/NearBranchTrampoline.h:11:18: note: attributes may be inserted here
     11 | PUBLIC extern "C" inline void dobby_set_near_trampoline(bool enable) {
        |                  ^
  gmake[3]: *** [CMakeFiles/dobby_static.dir/build.make:104: CMakeFiles/dobby_static.dir/source/core/assembler/assembler-x64.cc.o] Error 1
  gmake[3]: *** Waiting for unfinished jobs....
  In file included from /home/angel/projects/other-peoples/lovely-injector/crates/dobby-sys/dobby/./source/dobby/common.h:7:
  /home/angel/projects/other-peoples/lovely-injector/crates/dobby-sys/dobby/./source/dobby/utility_macro.h:60:16: warning: attributes are not permitted in this position [-Wattributes]
     60 | #define PUBLIC __attribute__((visibility("default")))
        |                ^~~~~~~~~~~~~
  /home/angel/projects/other-peoples/lovely-injector/crates/dobby-sys/dobby/./source/InterceptRouting/NearBranchTrampoline/NearBranchTrampoline.h:11:1: note: in expansion of macro 'PUBLIC'
     11 | PUBLIC extern "C" inline void dobby_set_near_trampoline(bool enable) {
        | ^~~~~~
  In file included from /home/angel/projects/other-peoples/lovely-injector/crates/dobby-sys/dobby/./source/InterceptRouting/InterceptRouting.h:8,
                   from /home/angel/projects/other-peoples/lovely-injector/crates/dobby-sys/dobby/./source/dobby/dobby_internal.h:13:
  /home/angel/projects/other-peoples/lovely-injector/crates/dobby-sys/dobby/./source/InterceptRouting/NearBranchTrampoline/NearBranchTrampoline.h:11:18: note: attributes may be inserted here
     11 | PUBLIC extern "C" inline void dobby_set_near_trampoline(bool enable) {
        |                  ^
  gmake[3]: *** [CMakeFiles/dobby_static.dir/build.make:188: CMakeFiles/dobby_static.dir/source/InstructionRelocation/x86/InstructionRelocationX86Shared.cc.o] Error 1
  gmake[3]: *** [CMakeFiles/dobby_static.dir/build.make:202: CMakeFiles/dobby_static.dir/source/InstructionRelocation/x64/InstructionRelocationX64.cc.o] Error 1
  gmake[2]: *** [CMakeFiles/Makefile2:164: CMakeFiles/dobby_static.dir/all] Error 2
  gmake[1]: *** [CMakeFiles/Makefile2:171: CMakeFiles/dobby_static.dir/rule] Error 2
  gmake: *** [Makefile:137: dobby_static] Error 2

  thread 'main' panicked at /home/angel/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/cmake-0.1.54/src/lib.rs:1119:5:

  command did not execute successfully, got: exit status: 2

  build script failed, must exit now
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

System Configuration:

$ uname -a
Linux debian 6.1.0-31-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.1.128-1 (2025-02-07) x86_64 GNU/Linux
a

[kasimeka]

looks like ur build is tripping over this change, since it introduces a submodule, did you clone the repo with --recursive?

[angelcaru]

I cloned with --recurse-submodules, is there a difference between that and --recursive?

[english5040]

You seem to be erroring on compiler-defined macros like __has_feature, what C/C++ compiler is usr/bin/cc (usr/bin/c++)?

[kasimeka]

im failing to build on linux too, i hit jmpews/Dobby#237 and a bunch of other random errors. following the comments i switched the submodule to commit 0932d69c320e786672361ab53825ba8f4245e9d3 and was able to build lovely.

here are my changes: https://github.com/janw4ld/lovely-injector/tree/dobby-linux-build, do they build for you?

[kasimeka]

the rename from Dobby -> dobby was required for me to get nix to pick up the submodule (this is probably a nix bug)

and dobby's tests can't link due to what looks like a cmake misconfig

>   = note: rust-lld: error: undefined symbol: DobbyBuildVersion
>           >>> referenced by dobby_sys.d6e84b7acef1af2-cgu.0
>           >>>               /build/kn5wz563x3cr03krzsidry0ayxvzg92b-source/target/x86_64-unknown-linux-gnu/release/deps/dobby_sys-5f2f3fbeae187b4b.dobby_sys.d6e84b7acef1af2-cgu.0.rcgu.o:(core::ops::function::FnOnce::call_once::ha93a91a81d786187)
>           collect2: error: ld returned 1 exit status
>

so i had to disable tests (by adding doCheck = false to the nix flake) to get the package to build.

[angelcaru]

You seem to be erroring on compiler-defined macros like __has_feature, what C/C++ compiler is usr/bin/cc (usr/bin/c++)?

angel@debian:~$ ll $(which cc) $(which c++)
lrwxrwxrwx 1 root root 21 ene  8  2023 /usr/bin/c++ -> /etc/alternatives/c++
lrwxrwxrwx 1 root root 20 ene  8  2023 /usr/bin/cc -> /etc/alternatives/cc
angel@debian:~$ ll $(which /etc/alternatives/cc) $(which /etc/alternatives/c++)
lrwxrwxrwx 1 root root 12 ene  8  2023 /etc/alternatives/c++ -> /usr/bin/g++
lrwxrwxrwx 1 root root 12 ene  8  2023 /etc/alternatives/cc -> /usr/bin/gcc
angel@debian:~$ gcc --version
gcc (Debian 12.2.0-14) 12.2.0
Copyright (C) 2022 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

angel@debian:~$ g++ --version
g++ (Debian 12.2.0-14) 12.2.0
Copyright (C) 2022 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

angel@debian:~$

[angelcaru]

im failing to build on linux too, i hit jmpews/Dobby#237 and a bunch of other random errors. following the comments i switched the submodule to commit 0932d69c320e786672361ab53825ba8f4245e9d3 and was able to build lovely.

here are my changes: https://github.com/janw4ld/lovely-injector/tree/dobby-linux-build, do they build for you?

In your fork I get:

$ cargo build --release
warning: unused imports: `pattern` and `regex`
  --> crates/lovely-core/src/lib.rs:18:13
   |
18 | use patch::{pattern, regex, Patch, PatchFile, Priority};
   |             ^^^^^^^  ^^^^^
   |
   = note: `#[warn(unused_imports)]` on by default

warning: `lovely-core` (lib) generated 1 warning (run `cargo fix --lib -p lovely-core` to apply 1 suggestion)
   Compiling windows v0.54.0
   Compiling lovely-win v0.1.0 (/home/angel/projects/other-peoples/lovely-injector-janwl4d/crates/lovely-win)
   Compiling ctor v0.2.9
error: failed to run custom build command for `lovely-win v0.1.0 (/home/angel/projects/other-peoples/lovely-injector-janwl4d/crates/lovely-win)`

Caused by:
  process didn't exit successfully: `/home/angel/projects/other-peoples/lovely-injector-janwl4d/target/release/build/lovely-win-9c80df5ee82f23b2/build-script-build` (exit status: 101)
  --- stderr

  thread 'main' panicked at crates/lovely-win/build.rs:13:84:
  called `Result::unwrap()` on an `Err` value: "Failed to read file: No such file or directory (os error 2)"
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
warning: build failed, waiting for other jobs to finish...

However, I did manage to get this version to build, which worked but it appears like it's very old (too old for stuff like balatro multiplayer)

[kasimeka]

@angelcaru idk why it picked the windows crate. could u try to build it with --package lovely-unix?

[english5040]

ugh, it seems like this problem is going to be awkward. I may be going in the wrong direction asking about compilers. I did a quick google search, found that gcc 12 doesn't seem to support __has_feature, it was added in gcc 14 for clang compatibility.

@ethangreen-dev let's find some time to work on the linux issues with Dobby

[english5040]

jmpews/Dobby#220 seems to be a relevant PR- while you're waiting you can try merging that and seeing what happens

[ethangreen-dev]

Unfortunate. Lets chat about possible mitigation options while jmpews/Dobby#220 is being worked on. #192 is fine in the meantime if a working older version can be found.

[kasimeka]

if a working older version can be found.

i only tested it with gcc 14, but i can try gcc 12 before making my PR ready for review.