Skip to content

kona|acceptance-tests: TestSequencerPreset does not support kona sequencer #18675

@pcw109550

Description

@pcw109550

Found while attempting to run monorepo acceptance tests targeting kona-node.

After init test:
https://github.com/op-rs/kona/blob/47b2f1c6ee1b340d65161c3a13160c8d070fec21/tests/node/reorgs/init_test.go

	l2Config := node_utils.ParseL2NodeConfigFromEnv()

	fmt.Printf("Running e2e reorg tests with Config: %d\n", l2Config)

	presets.DoMain(m, node_utils.WithMixedWithTestSequencer(l2Config))

Even if

		KonaSequencerNodesWithGeth: 1,
		KonaSequencerNodesWithReth: 1,

are enabled, preset WithMixedWithTestSequencer does not use these field

https://github.com/op-rs/kona/blob/47b2f1c6ee1b340d65161c3a13160c8d070fec21/tests/node/utils/test_sequencer_preset.go

leading that the kona sequencer not spawning even if the preset is configured.

Also need to take a look at this logic:

func WithMixedWithTestSequencer(l2Config L2NodeConfig) stack.CommonOption {
	if l2Config.OpSequencerNodesWithGeth == 0 && l2Config.OpSequencerNodesWithReth == 0 {
		l2Config.OpSequencerNodesWithGeth = 1
	}

So the preset is intentionally not using op-node sequencer, it overrides to use the op-node as a sequencer.

This causes simple-kona-sequencer network not spawning kona sequencer. For example, you can run

just test-e2e-sysgo-run node node/reorgs "simple-kona-sequencer" TestL2ReorgAfterL1Reorg

and check sequencer logs. The logs detail show op-node sequencer is spawned, which was not intended.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions