Skip to content

snag report on improved superchain-ops flow #1224

@geoknee

Description

@geoknee

Context: I was running through the signing flow for this task https://github.com/ethereum-optimism/superchain-ops/tree/main/src/tasks/sep/030-zora-sep-u13-to-u16a

Here are some things that confused me / tripped me up:

  1. When simulating the task, I get output like the folllowing:
**<TODO: Slot was not automatically decoded. Please provide a summary with thorough detail then remove this line.>**
  
**<TODO: Insert links for this state change then remove this line.>**
  
- **Key:**          `0x0000000000000000000000000000000000000000000000000000000000000005`
  - **Before:** `0x0000000000000000000000000000000000000000000000000000000000000000`
  - **After:** `0x0000000000000000000000000000000000000000000000000000000001cc7a2b`
  - **Summary:** 
  - **Detail:** 
  
**<TODO: Slot was not automatically decoded. Please provide a summary with thorough detail then remove this line.>**
  
**<TODO: Insert links for this state change then remove this line.>**
  
- **Key:**          `0x360894a13ba1a3210667c828492db98dca3e2076cc3735a920a3ca505d382bbc`
  - **Decoded Kind:** `address`
  - **Before:** `0x0000000000000000000000000000000000000000`
  - **After:** `0x7b465370BB7A333f99edd19599EB7Fb1c2D3F8D2`
  - **Summary:** ERC-1967 implementation slot
  - **Detail:** Standard slot for storing the implementation address in a proxy contract that follows the ERC-1967 standard.
  
**<TODO: Insert links for this state change then remove this line.>**
  
- **Key:**          `0xb53127684a568b3173ae13b9f8a6016e243e63b6e8ee1178d6a717850b5d6103`
  - **Decoded Kind:** `address`
  - **Before:** `0x0000000000000000000000000000000000000000`
  - **After:** `0xE17071F4C216Eb189437fbDBCc16Bb79c4efD9c2`
  - **Summary:** Proxy owner address
  - **Detail:** Standard slot for storing the owner address in a Proxy contract.
  
**<TODO: Insert links for this state change then remove this line.>**

I don't think we want to be printing all these TODOs?

  1. Readme and output stress the importance of checking a normalized state diff against an audit report, but I gather we don't have these any more.

  2. User is encouraged to use op-txverify, but I'm not clear that is a necessary step or not?

  3. How to use HD_PATH env variable does not seem to be documented.

  4. These links in the validation.md

3. [Verifying the transaction input](#understanding-task-calldata)
4. [Verifying the state changes](#task-state-changes)

are broken.

  1. I get a tenderly link to follow, but I don't know what to do with the simulation output since we don't validate the state diff any more.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions