Update EIP-7979: Validation algorithm on blockchain, other editing.#11744
Update EIP-7979: Validation algorithm on blockchain, other editing.#11744gcolvin wants to merge 15 commits into
Conversation
Put EVM code for canonical validation algorithm on the blockchain where it can be run by clients.
github-actions
Bot
added
c-update
eth-bot
changed the title
|
I am trying to remove the addresses of authors who no longer respond to those addresses, but the bot is insisting that they approve the change. Doom loop. |
gcolvin
changed the title
Clarified requirements for JUMP and JUMPI instructions in MAGIC code, ensuring they are preceded by a PUSH instruction. Expanded explanation on the implications of constant stack height and the validation of return addresses.
| description: Three new instructions to support calls and returns, with optional validated control flow. | ||
| author: Greg Colvin <greg@colvin.org>, Martin Holst Swende (@holiman), Brooklyn Zelenka (@expede), John Max Skaller <skaller@internode.on.net> | ||
| discussions-to: https://ethereum-magicians.org/t/eip-7951-call-and-return-opcodes-for-the-evm/24615 | ||
| author: Greg Colvin <greg@colvin.org>, Greg Colvin (@gcolvin), Martin Holst Swende, Brooklyn Zelenka, John Max Skaller |
There was a problem hiding this comment.
Hi Greg, while we do not have specific rules for this, removing the GitHub usernames of Martin Holst Swende and Brooklyn Zelenka would remove their right to approve changes to this EIP, and also changes the authorship list (by removing the email of John Max Skaller). I would strongly advice against this change and only adding yourself with your GitHub username to the authorship list of this EIP.
@holiman or @expede can then approve this alteration of this PR (or also approve the current change, removing their direct change rights).
Seeing that your GitHub account points to greg@colvin.org you also have the authority to merge here, but please consider not changing the handles of other authors before giving the approval.
If you still want to merge without changes, also let me know.
There was a problem hiding this comment.
Ugh, I should read PRs first, see you responded here #11744 (comment).
I just want to re-check, you want to remove these emails and GitHub handles?
There was a problem hiding this comment.
Maybe for completeness: changing an EIP does not require approval from all authors, one is enough. So if you add yourself you can thus also merge PRs to this EIP, you do not need approval from other authors. The blocker here is that the bot does not recognize you as author, but we can see as explained here #11744 (comment) that your account has the rights to make this change.
If the reason removing these author GitHub users is to bypass the bot, then this will not work and thus also is not necessary.
Then once you are ready to merge, give us a 👍 and we will do so.
There was a problem hiding this comment.
@jochem-brouwer
I'm very confused.
I'm not trying to add myself -- I've been there all along. I'm just trying to add my tag.
I am trying to get around the bot insisting that "Requires 1 more review from Authors: @expede, @holiman". Both deserve credit for the parts they wrote -- Brooklyn's analysis remains from EIP-615 and Martin's opcode specs and test cases remain from EIP-2315 -- but neither have any interest in this proposal anymore. Still, I'd as soon leave their tags in if the bot is lying.
John Max Skaller is deceased, so no point in leaving his email in.
| Copyright and related rights waived via CC0. | ||
| Copyright and related rights waived via CC0 | ||
|
|
||
| _Note: Significant assistance from Anthropic's Claude acknowledged._ |
There was a problem hiding this comment.
this should be removed as not part of standard copyright addendum
There was a problem hiding this comment.
Is there somewhere I should put it? I think it's important info. (I'm almost ashamed to have needed the assistance, but we lost John Max at a bad time.)
|
The commit 71d1866 (as a parent of 23134f6) contains errors. |
4 participants
Put EVM code for canonical validation algorithm on the blockchain where it can be run by clients.