Skip to content
This repository was archived by the owner on Feb 11, 2025. It is now read-only.

Modify break statement of nTime loop#46

Open
jaeykim wants to merge 1 commit into
ethereum:developfrom
jaeykim:develop
Open

Modify break statement of nTime loop#46
jaeykim wants to merge 1 commit into
ethereum:developfrom
jaeykim:develop

Conversation

@jaeykim
Copy link
Copy Markdown

@jaeykim jaeykim commented May 22, 2018

I think this break prevents the loop from starting the refetch again, because the statement always breaks the loop.
And also instance.heightToStartFetch = getLastBlockHeight() + 1 should be changed to instance.heightToStartFetch = heightToRefetch + 1

@jaeykim jaeykim closed this May 22, 2018
@jaeykim jaeykim reopened this May 22, 2018
@ethers
Copy link
Copy Markdown
Member

ethers commented Jul 23, 2018

Thanks! (Will merge when I get permissions back)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants