eof: Add caching of TXCREATE validation results

Author: gumb0

lib/evmone/execution_state.hpp

@@ -173,6 +173,7 @@ class ExecutionState
 private:
     evmc_tx_context m_tx = {};
     std::optional<std::unordered_map<evmc::bytes32, bytes_view>> m_initcodes;
+    std::unordered_map<evmc::bytes32, bool> m_initcodes_validity;
 
 public:
     /// Pointer to code analysis.
@@ -216,6 +217,7 @@ class ExecutionState
         deploy_container = {};
         m_tx = {};
         m_initcodes.reset();
+        m_initcodes_validity.clear();
         call_stack = {};
     }
 
@@ -247,5 +249,16 @@ class ExecutionState
         const auto it = m_initcodes->find(hash);
         return it != m_initcodes->end() ? it->second : bytes_view{};
     }
+
+    [[nodiscard]] std::optional<bool> get_initcode_validity(const evmc_bytes32& hash) noexcept
+    {
+        const auto it = m_initcodes_validity.find(hash);
+        return (it != m_initcodes_validity.end() ? std::optional{it->second} : std::nullopt);
+    }
+
+    void set_initcode_validity(const evmc_bytes32& hash, bool is_valid)
+    {
+        m_initcodes_validity[hash] = is_valid;
+    }
 };
 }  // namespace evmone

lib/evmone/instructions_calls.cpp

@@ -435,8 +435,18 @@ Result create_eof_impl(
 
     if constexpr (Op == OP_TXCREATE)
     {
-        const auto error_subcont = validate_eof(state.rev, ContainerKind::initcode, initcontainer);
-        if (error_subcont != EOFValidationError::success)
+        const auto validity = state.get_initcode_validity(initcode_hash);
+        bool is_valid = false;
+        if (validity.has_value())
+            is_valid = *validity;
+        else
+        {
+            const auto error_subcont =
+                validate_eof(state.rev, ContainerKind::initcode, initcontainer);
+            is_valid = (error_subcont == EOFValidationError::success);
+            state.set_initcode_validity(initcode_hash, is_valid);
+        }
+        if (!is_valid)
             return {EVMC_SUCCESS, gas_left};  // "Light" failure.
     }