eof: Add caching of TXCREATE validation results #1193
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1193 +/- ##
==========================================
+ Coverage 94.82% 94.84% +0.02%
==========================================
Files 171 171
Lines 19406 19501 +95
==========================================
+ Hits 18401 18496 +95
Misses 1005 1005
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
gumb0
force-pushed
the
eof/cache-txcreate-validation
branch
3 times, most recently
from
eb46837 to
c7c3809
Compare
gumb0
force-pushed
the
eof/cache-txcreate-validation
branch
from
c7c3809 to
b23a729
Compare
| tx.type = Transaction::Type::initcodes; | ||
| tx.initcodes.push_back(init_container); | ||
|
|
||
| constexpr auto iterations = 500; |
There was a problem hiding this comment.
as mentioned on the call, I'd also make a version with invalid EOF, and with a mix valid/invalid. But maybe enough to leave it for EEST.
There is also a twisted variant where the loop is handled by recursion, where an (erroneous) cache mechanism could clear the cache on every call depth level. Also possible better in EEST.
lib/evmone/execution_state.hpp
Outdated
| @@ -216,6 +217,7 @@ class ExecutionState | |||
| deploy_container = {}; | |||
| m_tx = {}; | |||
| m_initcodes.reset(); | |||
| m_initcodes_validity.clear(); | |||
There was a problem hiding this comment.
I think it is better to combine this with m_initcodes: to have value as struct {bytes_view, std::optional<bool>} or struct {bytes_view, bool}.
There was a problem hiding this comment.
will have to have optional, I mostly decided against this originally because of this cumbersome structure
lib/evmone/instructions_calls.cpp
Outdated
| @@ -435,8 +435,18 @@ Result create_eof_impl( | |||
|
|
|||
| if constexpr (Op == OP_TXCREATE) | |||
| { | |||
| const auto error_subcont = validate_eof(state.rev, ContainerKind::initcode, initcontainer); | |||
| if (error_subcont != EOFValidationError::success) | |||
| const auto validity = state.get_initcode_validity(initcode_hash); | |||
There was a problem hiding this comment.
This section is unnecessarily separated from the other TXCREATE processing section above. I think we should reorder them and place the endowment and depth checks before the get_tx_initcode_by_hash() section.
Then we will be able to combine the get_tx_initcode_by_hash() and set_initcode_validity, potentially with having single unordered_map.
There was a problem hiding this comment.
Problem is pos has to be updated before light failures
(and differently for EOFCREATE and TXCREATE)
I pushed one possible version, without unifying initcode and validity query yet.
gumb0
force-pushed
the
eof/cache-txcreate-validation
branch
2 times, most recently
from
1265290 to
3a4be96
Compare
gumb0
force-pushed
the
eof/cache-txcreate-validation
branch
2 times, most recently
from
44863a1 to
aec7428
Compare
Co-authored-by: Paweł Bylica <[email protected]>
gumb0
force-pushed
the
eof/cache-txcreate-validation
branch
from
2880d00 to
d1bc275
Compare
No description provided.