precompiles: Implement expmod with GMP #1198
Open
+114
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chfast
added
precompiles
chfast
force-pushed
the
precompiles/expmod_gmp
branch
from
592d65b to
9e8c99a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1198 +/- ##
==========================================
- Coverage 94.84% 94.79% -0.05%
==========================================
Files 171 172 +1
Lines 19501 19515 +14
==========================================
+ Hits 18496 18500 +4
- Misses 1005 1015 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
chfast
force-pushed
the
precompiles/expmod_input
branch
2 times, most recently
from
e015ea5 to
36e817f
Compare
chfast
force-pushed
the
precompiles/expmod_gmp
branch
from
9e8c99a to
647213b
Compare
chfast
commented
Apr 15, 2025
test/state/CMakeLists.txt
Outdated
| @@ -72,3 +72,16 @@ if(EVMONE_PRECOMPILES_SILKPRE) | |||
| precompiles_silkpre.cpp | |||
| ) | |||
| endif() | |||
|
|
|||
| # This is done after Silkpre because it also tries to find GMP. | |||
| option(EVMONE_PRECOMPILES_GMP "Enable precompiles implementations via the GMP/MPIR library" ON) | |||
There was a problem hiding this comment.
On by default seems to cause a lot of build issues. Maybe use the same strategy as with SILKPRE (OFF by default).
| @@ -72,3 +72,16 @@ if(EVMONE_PRECOMPILES_SILKPRE) | |||
| precompiles_silkpre.cpp | |||
| ) | |||
| endif() | |||
|
|
|||
| # This is done after Silkpre because it also tries to find GMP. | |||
There was a problem hiding this comment.
SILKPRE option stays for benchmarking purposes only.
| mpz_import(b, base.size(), 1, 1, 0, 0, base.data()); | ||
| mpz_import(e, exp.size(), 1, 1, 0, 0, exp.data()); | ||
| mpz_import(m, mod.size(), 1, 1, 0, 0, mod.data()); | ||
| assert(mpz_sgn(m) != 0); |
There was a problem hiding this comment.
I should document in the expmod_xxx interface that the mod is expected non-zero.
rodiazet
approved these changes
Apr 15, 2025
chfast
force-pushed
the
precompiles/expmod_gmp
branch
from
647213b to
b134080
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.