-
Notifications
You must be signed in to change notification settings - Fork 463
Open
Description
Transaction RPC responses have v and gasPrice fields marked as deprecated, thus they are not required. But the generated test fixtures for Hive tests do have them. So any client that does not return these fields will fail the tests.
Such behavior creates confusion regarding what should be considered "spec compliant". While it makes sense to keep these fields for backward compatibility for legacy RPC consumers, it also makes it hard to understand how to approach such discrepancies.
I see a few solutions to address this issue:
- filter out non-required fields on test fixture generation and/or hive tests
- mark these fields as required
Which IMO not ideal. Were there any discussions in this regard?
Metadata
Metadata
Assignees
Labels
No labels