feat(fill,tests): add all static GeneralStateTestsFiller from ethereum/tests (#1442)

* feat(tests/static): all ethereum/tests state_test fillers

fix(tests): Rename modules to comply with python naming system

fix(tests): Mark stTimeConsuming as slow

fix(tests): Skip deprecated/duplicated blob tests

fix(tests/legacy): All state tests start on block 1

docs: Changelog

fix(tests): Remove static blob tests altogether

refactor: rename

rename

feat(tests): Add tests/static/README.md

readme changes

* Update docs/CHANGELOG.md

Co-authored-by: danceratopz <[email protected]>

* Update CHANGELOG.md

---------

Co-authored-by: Mario Vega <[email protected]>
Co-authored-by: danceratopz <[email protected]>

Author: 3 people

docs/CHANGELOG.md

@@ -22,6 +22,7 @@ Test fixtures for use by clients are available for each release on the [Github r
 
 - ✨ [EIP-7702](https://eips.ethereum.org/EIPS/eip-7702): Test that DELEGATECALL to a 7702 target works as intended ([#1485](https://github.com/ethereum/execution-spec-tests/pull/1485)).
 - ✨ [EIP-2573](https://eips.ethereum.org/EIPS/eip-2537): Includes a BLS12 point generator, alongside additional coverage many of the precompiles ([#1350](https://github.com/ethereum/execution-spec-tests/pull/1350)).
+- ✨ Add all [`GeneralStateTests` from `ethereum/tests`](https://github.com/ethereum/tests/tree/7dc757ec132e372b6178a016b91f4c639f366c02/src/GeneralStateTestsFiller) to `execution-spec-tests` located now at [tests/legacy/state_tests](https://github.com/ethereum/execution-spec-tests/tree/main/tests/legacy/state_tests) ([#1442](https://github.com/ethereum/execution-spec-tests/pull/1442)).
 
 ## [v4.3.0](https://github.com/ethereum/execution-spec-tests/releases/tag/v4.3.0) - 2025-04-18
 

tests/static/README.md

@@ -0,0 +1,12 @@
+# Static Tests
+
+This directory contains static test files that were originally located at [ethereum/tests](https://github.com/ethereum/tests/tree/develop/src). These files should not be modified directly.
+
+## Important Policy
+
+If you find a test that is broken or needs updating:
+
+1. **DO NOT** modify the static test files directly.
+2. Instead, create or update the corresponding Python test in the appropriate `tests/<fork>` folder.
+3. Delete the original static test filler file(s).
+4. Open a PR containing the new tests and the static tests deletion, and make sure that there is no coverage drop.

tests/static/__init__.py

@@ -0,0 +1,4 @@
+"""Static State Tests Fillers from ethereum/tests repo."""
+
+REFERENCE_SPEC_GIT_PATH = ""
+REFERENCE_SPEC_VERSION = ""

tests/static/state_tests/Cancun/__init__.py

@@ -0,0 +1,4 @@
+"""Static State Tests Fillers from ethereum/tests repo."""
+
+REFERENCE_SPEC_GIT_PATH = ""
+REFERENCE_SPEC_VERSION = ""

tests/static/state_tests/Cancun/stEIP1153_transientStorage/10_revertUndoesStoreAfterReturnFiller.yml

@@ -0,0 +1,110 @@
+# 10
+# Revert undoes transient storage writes from inner calls that successfully returned.
+# TSTORE(x, y), CALL(self, ...), CALL(self, ...), TSTORE(x, y + 1), RETURN, REVERT, TLOAD(x) returns y
+#
+# Expect slot 0 to have 5 from the first tstore & tload.
+# Expect slot 1 to have 0. Call was unsuccessful.
+# Expect slot 2 to have 1. Inner call was successful.
+# Expect slot 3 to have 5. Should load the value stored before the unsuccessful call.
+
+10_revertUndoesStoreAfterReturn:
+  _info:
+    comment: Revert undoes the transient storage writes after a successful call.
+
+  env:
+    currentCoinbase: 2adc25665018aa1fe0e6bc666dac8fc2697ff9ba
+    currentDifficulty: 0x20000
+    currentNumber: 1
+    currentTimestamp: 1000
+    currentGasLimit: 0x10000000000000
+    currentBaseFee: 10
+
+  pre:
+    A00000000000000000000000000000000000000A:
+      balance: 1000000000000000000
+      nonce: 0
+      code: |
+        :yul {
+          switch selector()
+
+          case 0x70ac643e { // doFirstCall()
+            doFirstCall()
+          }
+
+          case 0x76b85d23 { // doCallThenRevert()
+            doCallThenRevert()
+          }
+
+          case 0x4ccca553 { // doSuccessfulStore()
+            doSuccessfulStore()
+          }
+
+          function doFirstCall() {
+            verbatim_2i_0o(hex"5D", 0, 5)
+
+            let v := verbatim_1i_1o(hex"5C", 0)
+            sstore(0, v)
+
+            mstore(0, hex"76b85d23") // calls doCallThenRevert()
+            let fail := call(gas(), address(), 0, 0, 32, 0, 32)
+
+            sstore(1, fail) // should be 0 (revert)
+            sstore(2, mload(0)) // load 1 (successful call)
+
+            let val := verbatim_1i_1o(hex"5C", 0)
+            sstore(3, val)
+          }
+
+          
+          function doCallThenRevert() {
+            mstore(0, hex"4ccca553") // calls doSuccessfulStore()
+            let s := call(gas(), address(), 0, 0, 32, 0, 0)
+            mstore(0, s)
+            revert(0, 32)
+          }
+
+          function doSuccessfulStore() {
+            verbatim_2i_0o(hex"5D", 0, 6)
+          }
+
+          function doReenter(fs) -> f {
+             mstore(0, fs)
+             f := call(gas(), address(), 0, 0, 32, 0, 0)
+           }
+
+          function selector() -> s {
+            let value := calldataload(0)
+            s := shr(224, value)
+          }
+        }
+      storage: { 0x01: 0xffff }
+    a94f5374fce5edbc8e2a8697c15331677e6ebf0b:
+      balance: 1000000000000000000000
+      code: "0x"
+      nonce: 0
+      storage: {}
+
+  transaction:
+    data:
+      - data: :abi doFirstCall()
+        accessList: []
+    gasLimit:
+      - "400000"
+    nonce: 0
+    to: A00000000000000000000000000000000000000A
+    value:
+      - 0
+    secretKey: "45a915e4d060149eb4365960e6a7a45f334393093061116b197e3240065ff2d8"
+    maxPriorityFeePerGas: 0
+    maxFeePerGas: 2000
+
+  expect:
+    - network:
+        - ">=Cancun"
+      result:
+        A00000000000000000000000000000000000000A:
+          storage:
+            0x00: 5
+            0x01: 0
+            0x02: 1
+            0x03: 5

tests/static/state_tests/Cancun/stEIP1153_transientStorage/14_revertAfterNestedStaticcallFiller.yml

@@ -0,0 +1,103 @@
+# 14
+# Transient storage cannot be manipulated in a nested static context: TSTORE(x, y), STATICCALL(self, ...), CALL(self, ...), TSTORE(x, z) reverts
+#
+# Expect slot 0 to have 10 from the first tstore & tload.
+# Expect slot 1 to have 0 (for revert).
+# Expect slot 2 to have 1 (for success).
+# Expect slot 3 to have 10 (original value).
+
+14_revertAfterNestedStaticcall:
+  _info:
+    comment: Transient storage can't be manipulated from nested staticcall.
+
+  env:
+    currentCoinbase: 2adc25665018aa1fe0e6bc666dac8fc2697ff9ba
+    currentDifficulty: 0x20000
+    currentNumber: 1
+    currentTimestamp: 1000
+    currentGasLimit: 0x10000000000000
+    currentBaseFee: 10
+
+  pre:
+    A00000000000000000000000000000000000000A:
+      balance: 1000000000000000000
+      nonce: 0
+      code: |
+        :yul {
+          switch selector()
+
+          case 0xf5f40590 { // doStoreAndStaticCall()
+            doStoreAndStaticCall()
+          }
+
+          case 0xf8dfc2d0 { // doCallToStore()
+            doCallToStore()
+          }
+
+          case 0x62fdb9be { // doStore()
+            doStore()
+          }
+
+          function doStoreAndStaticCall() {
+            verbatim_2i_0o(hex"5D", 0, 10)
+
+            let v := verbatim_1i_1o(hex"5C", 0)
+            sstore(0, v)
+
+            mstore(0, hex"f8dfc2d0") // doCallToStore()
+            let success := staticcall(0xffff, address(), 0, 32, 0, 32)
+            
+            sstore(1, mload(0)) // should be 0 from nested unsuccessful call
+            sstore(2, success) // should be 1
+
+            let val := verbatim_1i_1o(hex"5C", 0)
+            sstore(3, val)
+          }
+          
+          function doCallToStore() {
+            mstore(0, hex"62fdb9be") // doStore()
+            let f := call(gas(), address(), 0, 0, 32, 0, 0) // call with zero-value
+            mstore(0, f)
+            return(0, 32)
+          }
+
+          function doStore() {
+            verbatim_2i_0o(hex"5D", 0, 11) // will revert
+          }
+
+          function selector() -> s {
+            let value := calldataload(0)
+            s := shr(224, value)
+          }
+        }
+      storage: { 0x01: 0xffff }
+    a94f5374fce5edbc8e2a8697c15331677e6ebf0b:
+      balance: 1000000000000000000000
+      code: "0x"
+      nonce: 0
+      storage: {}
+
+  transaction:
+    data:
+      - data: :abi doStoreAndStaticCall()
+        accessList: []
+    gasLimit:
+      - "400000"
+    nonce: 0
+    to: A00000000000000000000000000000000000000A
+    value:
+      - 0
+    secretKey: "45a915e4d060149eb4365960e6a7a45f334393093061116b197e3240065ff2d8"
+    maxPriorityFeePerGas: 0
+    maxFeePerGas: 2000
+
+  expect:
+    - network:
+        - ">=Cancun"
+      result:
+        A00000000000000000000000000000000000000A:
+          storage:
+            0x00: 10
+            0x01: 0
+            0x02: 1
+            0x03: 10

tests/static/state_tests/Cancun/stEIP1153_transientStorage/15_tstoreCannotBeDosdFiller.yml

@@ -0,0 +1,92 @@
+# 15
+# Transient storage cannot be DOS’d: CALL(self, ...), TSTORE(x, y), TSTORE(x + 1, y), TSTORE(x + 2, y), ... ,TSTORE(x + n, y), REVERT, TLOAD(x) returns 0 and runs in under 15 seconds
+#
+# Expect slot 0 to have 0. Call fails.
+# Expect slot 1 to have 0. Loading returns 0.
+
+15_tstoreCannotBeDosd:
+  _info:
+    comment: Transient storage cannot be DOS’d.
+
+  env:
+    currentCoinbase: 2adc25665018aa1fe0e6bc666dac8fc2697ff9ba
+    currentDifficulty: 0x20000
+    currentNumber: 1
+    currentTimestamp: 1000
+    currentGasLimit: 0x10000000000000
+    currentBaseFee: 10
+
+  pre:
+    A00000000000000000000000000000000000000A:
+      balance: 1000000000000000000
+      nonce: 0
+      code: |
+        :yul {
+          switch selector()
+
+          case 0x883264e8 { // doCall(uint)
+            let n:= calldataload(4)
+            doCall(n)
+          }
+
+          case 0xf7d6c0eb { // doNStores(n)
+            let n := calldataload(32)
+            doNStores(n)
+          }
+
+          function doCall(n) {
+            mstore(0, hex"f7d6c0eb") // doNStores(n)
+            mstore(32, n)
+            let t := call(gas(), address(), 0, 0, 64, 0, 32)
+            sstore(0, t) // should revert
+
+            sstore(2, mload(0))
+
+            let v := verbatim_1i_1o(hex"5C", 0)
+            sstore(1, v)
+          }
+
+          function doNStores(n) {
+            let i
+            for {i := 0 } lt(i, n) { i := add(i, 1) } {
+              verbatim_2i_0o(hex"5D", i, 48)
+            }
+            mstore(0, i)
+            revert(0, 32)
+          }
+
+          function selector() -> s {
+            let value := calldataload(0)
+            s := shr(224, value)
+          }
+        }
+      storage: { 0x00: 0xffff, 0x01: 0xffff }
+    a94f5374fce5edbc8e2a8697c15331677e6ebf0b:
+      balance: 1000000000000000000000
+      code: "0x"
+      nonce: 0
+      storage: {}
+
+  transaction:
+    data:
+      - data: :abi doCall(uint) 0x249F0
+        accessList: []
+    gasLimit:
+      - "30000000"
+    nonce: 0
+    to: A00000000000000000000000000000000000000A
+    value:
+      - 0
+    secretKey: "45a915e4d060149eb4365960e6a7a45f334393093061116b197e3240065ff2d8"
+    maxPriorityFeePerGas: 0
+    maxFeePerGas: 2000
+
+  expect:
+    - network:
+        - ">=Cancun"
+      result:
+        A00000000000000000000000000000000000000A:
+          storage:
+            0x00: 0
+            0x01: 0
+            0x02: 0x249F0

tests/static/state_tests/Cancun/stEIP1153_transientStorage/17_tstoreGasFiller.yml

@@ -0,0 +1,59 @@
+# 17
+# Tstore arbitrary value in arbitrary slot costs 100 gas : TSTORE(x, y) costs 100 gas.
+#
+# Expect storage slot 1 to be 100. Cost of tstore.
+
+17_tstoreGas:
+  _info:
+    comment: Tstore arbitrary value in arbitrary slot costs 100 gas.
+
+  env:
+    currentCoinbase: 2adc25665018aa1fe0e6bc666dac8fc2697ff9ba
+    currentDifficulty: 0x20000
+    currentNumber: 1
+    currentTimestamp: 1000
+    currentGasLimit: 0x10000000000000
+    currentBaseFee: 10
+
+  pre:
+    A00000000000000000000000000000000000000A:
+      balance: 1000000000000000000
+      nonce: 0
+      code: |
+        :yul {
+          let extraOpcodes := 7
+          
+          // calculate tstore gas
+          let g1 := gas()
+          verbatim_2i_0o(hex"5D", 0, 3)
+          let g2 := gas()
+          sstore(1, sub(sub(g1, g2), extraOpcodes))
+        }
+      storage: {}
+    a94f5374fce5edbc8e2a8697c15331677e6ebf0b:
+      balance: 1000000000000000000000
+      code: "0x"
+      nonce: 0
+      storage: {}
+
+  transaction:
+    data:
+      - data: 0x
+        accessList: []
+    gasLimit:
+      - "400000"
+    nonce: 0
+    to: A00000000000000000000000000000000000000A
+    value:
+      - 0
+    secretKey: "45a915e4d060149eb4365960e6a7a45f334393093061116b197e3240065ff2d8"
+    maxPriorityFeePerGas: 0
+    maxFeePerGas: 2000
+
+  expect:
+    - network:
+        - ">=Cancun"
+      result:
+        A00000000000000000000000000000000000000A:
+          storage:
+            0x01: 100