Updates based on feedback

Author: Stuart Reed

tests/frontier/identity_precompile/common.py

@@ -3,6 +3,8 @@
 from dataclasses import dataclass
 from typing import Tuple
 
+from pydantic import BaseModel
+
 from ethereum_test_base_types.composite_types import Storage
 from ethereum_test_tools import (
     Bytecode,
@@ -17,25 +19,16 @@ class Constants:
     IDENTITY_PRECOMPILE_ADDRESS = 0x04
 
 
-class CallArgs:
+class CallArgs(BaseModel):
     """Defines inputs to CALL for the Identity precompile."""
 
-    def __init__(
-        self,
-        gas=0x1F4,
-        value=0x0,
-        args_offset=0x0,
-        args_size=0x20,
-        ret_offset=0x0,
-        ret_size=0x20,
-    ):
-        """Create a new instance with the provided values."""
-        self.gas = gas
-        self.value = value
-        self.args_offset = args_offset
-        self.args_size = args_size
-        self.ret_offset = ret_offset
-        self.ret_size = ret_size
+    address: int = Constants.IDENTITY_PRECOMPILE_ADDRESS
+    gas: int = 0x1F4
+    value: int = 0x0
+    args_offset: int = 0x0
+    args_size: int = 0x20
+    ret_offset: int = 0x0
+    ret_size: int = 0x20
 
 
 def generate_identity_call_bytecode(
@@ -76,15 +69,7 @@ def generate_identity_call_bytecode(
     code += (
         Op.SSTORE(
             storage.store_next(call_succeeds),
-            call_type(
-                gas=call_args.gas,
-                address=Constants.IDENTITY_PRECOMPILE_ADDRESS,
-                value=call_args.value,
-                args_offset=call_args.args_offset,
-                args_size=call_args.args_size,
-                ret_offset=call_args.ret_offset,
-                ret_size=call_args.ret_size,
-            ),
+            call_type(**call_args.model_dump()),
         )
         + Op.SSTORE(storage.store_next(mstore_value), Op.MLOAD(mstore_offset))
         + Op.STOP

tests/frontier/identity_precompile/test_identity.py

@@ -34,10 +34,10 @@
             id="identity_1",
         ),
         pytest.param(
-            CallArgs(gas=0x30D40, value=0x13, args_size=0x0),
+            CallArgs(gas=0x30D40, value=0x1, args_size=0x0),
             None,
             False,
-            id="identity_1_nonzero",
+            id="identity_1_nonzerovalue",
         ),
         pytest.param(
             CallArgs(args_size=0x25),
@@ -61,13 +61,13 @@
             CallArgs(gas=0x11),
             (0xFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF,),
             False,
-            id="identity_4_gas17",
+            id="identity_4_insufficient_gas",
         ),
         pytest.param(
             CallArgs(gas=0x12),
             (0xFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF,),
             True,
-            id="identity_4_gas18",
+            id="identity_4_exact_gas",
         ),
     ],
 )

tests/frontier/identity_precompile/test_identity_returndatasize.py

@@ -18,8 +18,8 @@
 @pytest.mark.parametrize(
     ["args_size", "output_size", "expected_returndatasize"],
     [
-        pytest.param(16, 32, 16, id="output_16"),
-        pytest.param(32, 16, 32, id="output_32"),
+        pytest.param(16, 32, 16, id="output_size_greater_than_input"),
+        pytest.param(32, 16, 32, id="output_size_less_than_input"),
     ],
 )
 def test_identity_precompile_returndata(