new(tests): EOF validation JUMPF stack overflow (#1269)

Author: chfast

converted-ethereum-tests.txt

@@ -20,6 +20,7 @@ EOFTests/efStack/backwards_rjump_.json
 EOFTests/efStack/backwards_rjump_variable_stack_.json
 EOFTests/efStack/backwards_rjumpi_.json
 EOFTests/efStack/backwards_rjumpi_variable_stack_.json
+EOFTests/efStack/jumpf_stack_overflow_.json
 EOFTests/efStack/forwards_rjump_.json
 EOFTests/efStack/forwards_rjump_variable_stack_.json
 EOFTests/efStack/forwards_rjumpi_.json

tests/osaka/eip7692_eof_v1/eip6206_jumpf/test_jumpf_validation.py

@@ -7,6 +7,7 @@
 from ethereum_test_tools.vm.opcode import Opcodes as Op
 
 from .. import EOF_FORK_NAME
+from ..eip4750_functions.test_code_validation import MAX_RUNTIME_OPERAND_STACK_HEIGHT
 
 REFERENCE_SPEC_GIT_PATH = "EIPS/eip-6206.md"
 REFERENCE_SPEC_VERSION = "2f365ea0cd58faa6e26013ea77ce6d538175f7d0"
@@ -136,3 +137,46 @@ def test_returning_section_aborts_jumpf(
         ],
     )
     eof_test(container=container)
+
+
+@pytest.mark.parametrize("stack_height", [512, 513, 1023])
+def test_jumpf_self_stack_overflow(eof_test: EOFTestFiller, stack_height: int):
+    """Test JUMPF instruction jumping to itself causing validation time stack overflow."""
+    container = Container(
+        sections=[
+            Section.Code(
+                code=(Op.PUSH0 * stack_height) + Op.JUMPF[0],
+                max_stack_height=stack_height,
+            ),
+        ],
+    )
+    stack_overflow = stack_height > MAX_RUNTIME_OPERAND_STACK_HEIGHT // 2
+    eof_test(
+        container=container,
+        expect_exception=EOFException.STACK_OVERFLOW if stack_overflow else None,
+    )
+
+
+@pytest.mark.parametrize("stack_height_other", [1, 2, 512, 513, 1023])
+@pytest.mark.parametrize("stack_height", [1, 2, 512, 513, 1023])
+def test_jumpf_other_stack_overflow(
+    eof_test: EOFTestFiller, stack_height: int, stack_height_other: int
+):
+    """Test JUMPF instruction jumping to itself causing validation time stack overflow."""
+    container = Container(
+        sections=[
+            Section.Code(
+                code=(Op.PUSH0 * stack_height) + Op.JUMPF[1],
+                max_stack_height=stack_height,
+            ),
+            Section.Code(
+                code=(Op.PUSH0 * stack_height_other) + Op.STOP,
+                max_stack_height=stack_height_other,
+            ),
+        ],
+    )
+    stack_overflow = stack_height + stack_height_other > MAX_RUNTIME_OPERAND_STACK_HEIGHT
+    eof_test(
+        container=container,
+        expect_exception=EOFException.STACK_OVERFLOW if stack_overflow else None,
+    )

tests/osaka/eip7692_eof_v1/eof_tracker.md

@@ -296,8 +296,8 @@
 
 ##### JUMPF
 
-- [ ] Max allowed stack height reached in JUMPF-ed function (ethereum/tests: src/EOFTestsFiller/efStack/jumpf_stack_overflow_Copier.json)
-- [ ] JUMPF validation time stack overflow (ethereum/tests: src/EOFTestsFiller/efStack/jumpf_stack_overflow_Copier.json)
+- [x] Max allowed stack height reached in JUMPF-ed function ([`tests/osaka/eip7692_eof_v1/eip6206_jumpf/test_jumpf_validation.py::test_jumpf_other_stack_overflow`](./eip6206_jumpf/test_jumpf_validation/test_jumpf_other_stack_overflow.md))
+- [x] JUMPF validation time stack overflow ([`tests/osaka/eip7692_eof_v1/eip6206_jumpf/test_jumpf_validation.py::test_jumpf_other_stack_overflow`](./eip6206_jumpf/test_jumpf_validation/test_jumpf_other_stack_overflow.md))
 - [ ] Max allowed stack height reached in JUMPF-ed function with inputs
 - [ ] JUMPF validation time stack overflow in function with inputs (ethereum/tests: src/EOFTestsFiller/efStack/jumpf_with_inputs_stack_overflow_Copier.json)
 - [ ] JUMPF validation time stack overflow in function with inputs, variable stack segment, only max overflow (ethereum/tests: src/EOFTestsFiller/efStack/jumpf_with_inputs_stack_overflow_variable_stack_Copier.json)