Skip to content

bug(fill): confusing error with an invalid local eels resolver path #1090

Open
@danceratopz

Description

@danceratopz

If an error is made in a local path specified in eels_resolution.json such as:

    "London": {
        "path" : "../../execution-specs/src/ethereum/loooondon"
    },

then fill executed with, for example,

uv run fill --fork=London -x -v tests/istanbul/eip1344_chainid/ -m state_test

returns the error message:

INTERNALERROR> Traceback (most recent call last):
INTERNALERROR>   File "/home/dtopz/code/github/danceratopz/eest/.venv/lib/python3.12/site-packages/_pytest/main.py", line 267, in wrap_session
INTERNALERROR>     config._do_configure()
INTERNALERROR>   File "/home/dtopz/code/github/danceratopz/eest/.venv/lib/python3.12/site-packages/_pytest/config/__init__.py", line 1053, in _do_configure
INTERNALERROR>     self.hook.pytest_configure.call_historic(kwargs=dict(config=self))
INTERNALERROR>   File "/home/dtopz/code/github/danceratopz/eest/.venv/lib/python3.12/site-packages/pluggy/_hooks.py", line 535, in call_historic
INTERNALERROR>     res = self._hookexec(self.name, self._hookimpls.copy(), kwargs, False)
INTERNALERROR>           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
INTERNALERROR>   File "/home/dtopz/code/github/danceratopz/eest/.venv/lib/python3.12/site-packages/pluggy/_manager.py", line 120, in _hookexec
INTERNALERROR>     return self._inner_hookexec(hook_name, methods, kwargs, firstresult)
INTERNALERROR>            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
INTERNALERROR>   File "/home/dtopz/code/github/danceratopz/eest/.venv/lib/python3.12/site-packages/pluggy/_callers.py", line 139, in _multicall
INTERNALERROR>     raise exception.with_traceback(exception.__traceback__)
INTERNALERROR>   File "/home/dtopz/code/github/danceratopz/eest/.venv/lib/python3.12/site-packages/pluggy/_callers.py", line 103, in _multicall
INTERNALERROR>     res = hook_impl.function(*args)
INTERNALERROR>           ^^^^^^^^^^^^^^^^^^^^^^^^^
INTERNALERROR>   File "/home/dtopz/code/github/danceratopz/eest/src/pytest_plugins/forks/forks.py", line 518, in pytest_configure
INTERNALERROR>     t8n = TransitionTool.from_binary_path(binary_path=evm_bin)
INTERNALERROR>           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
INTERNALERROR>   File "/home/dtopz/code/github/danceratopz/eest/src/ethereum_clis/ethereum_cli.py", line 122, in from_binary_path
INTERNALERROR>     raise UnknownCLIError(f"Unknown CLI: {binary_path}")
INTERNALERROR> ethereum_clis.ethereum_cli.UnknownCLIError: Unknown CLI: ethereum-spec-evm-resolver

It would be helpful to return the underlying error returned by the ethereum-spec-evm-resolver.

Metadata

Metadata

Assignees

No one assigned

    Labels

    scope:evmScope: evm_transition_tool packagetype:bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions