eth/downloader, eth/protocols: clean up todos

jrhea · jrhea · commit 028610375a83 · 2026-04-03T14:41:45.000-05:00
diff --git a/eth/downloader/downloader.go b/eth/downloader/downloader.go
@@ -1080,8 +1080,8 @@ func (d *Downloader) DeliverSnapPacket(peer *snap.Peer, packet snap.Packet) erro
 		return d.SnapSyncer.OnByteCodes(peer, packet.ID, packet.Codes)
 
 	case *snap.TrieNodesPacket:
-		// Snap/2 no longer requests trie nodes; ignore stale responses
-		// TODO JR: Delete this
+		// Snap/2 no longer requests trie nodes. Stale responses from
+		// snap/1 peers are silently ignored.
 		return nil
 
 	case *snap.AccessListsPacket:
diff --git a/eth/protocols/snap/bal_apply.go b/eth/protocols/snap/bal_apply.go
@@ -56,7 +56,6 @@ func (s *Syncer) applyAccessList(b *bal.BlockAccessList) error {
 		if data := rawdb.ReadAccountSnapshot(s.db, accountHash); len(data) > 0 {
 			existing, err := types.FullAccount(data)
 			if err != nil {
-				// TODO JR: What to do in this case?
 				return fmt.Errorf("failed to decode account %v: %w", addr, err)
 			}
 			account = *existing

Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,6 @@ func (s Syncer) applyAccessList(b bal.BlockAccessList) error {`
`56`	`56`	`if data := rawdb.ReadAccountSnapshot(s.db, accountHash); len(data) > 0 {`
`57`	`57`	`existing, err := types.FullAccount(data)`
`58`	`58`	`if err != nil {`
`59`		`- // TODO JR: What to do in this case?`
`60`	`59`	`return fmt.Errorf("failed to decode account %v: %w", addr, err)`
`61`	`60`	`}`
`62`	`61`	`account = *existing`