From 41467e8287c2fd01b39832897722d09a5fd418c2 Mon Sep 17 00:00:00 2001
From: Lessa <230214854+adblesss@users.noreply.github.com>
Date: Thu, 29 Jan 2026 16:20:46 -0500
Subject: [PATCH] types,ethapi,signer: avoid copying 128KB blobs in range loops

---
 core/types/tx_blob.go               |  4 ++--
 internal/ethapi/transaction_args.go | 12 ++++++------
 signer/core/apitypes/types.go       | 10 +++++-----
 3 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/core/types/tx_blob.go b/core/types/tx_blob.go
index bbfd3c98db30..31aadb5419fa 100644
--- a/core/types/tx_blob.go
+++ b/core/types/tx_blob.go
@@ -118,8 +118,8 @@ func (sc *BlobTxSidecar) ToV1() error {
 	}
 	if sc.Version == BlobSidecarVersion0 {
 		proofs := make([]kzg4844.Proof, 0, len(sc.Blobs)*kzg4844.CellProofsPerBlob)
-		for _, blob := range sc.Blobs {
-			cellProofs, err := kzg4844.ComputeCellProofs(&blob)
+		for i := range sc.Blobs {
+			cellProofs, err := kzg4844.ComputeCellProofs(&sc.Blobs[i])
 			if err != nil {
 				return err
 			}
diff --git a/internal/ethapi/transaction_args.go b/internal/ethapi/transaction_args.go
index 23aa8e5947a6..22d1adfa57cf 100644
--- a/internal/ethapi/transaction_args.go
+++ b/internal/ethapi/transaction_args.go
@@ -329,8 +329,8 @@ func (args *TransactionArgs) setBlobTxSidecar(ctx context.Context, config sideca
 			commitments = make([]kzg4844.Commitment, n)
 			proofs      = make([]kzg4844.Proof, 0, proofLen)
 		)
-		for i, b := range args.Blobs {
-			c, err := kzg4844.BlobToCommitment(&b)
+		for i := range args.Blobs {
+			c, err := kzg4844.BlobToCommitment(&args.Blobs[i])
 			if err != nil {
 				return fmt.Errorf("blobs[%d]: error computing commitment: %v", i, err)
 			}
@@ -338,13 +338,13 @@ func (args *TransactionArgs) setBlobTxSidecar(ctx context.Context, config sideca
 
 			switch config.blobSidecarVersion {
 			case types.BlobSidecarVersion0:
-				p, err := kzg4844.ComputeBlobProof(&b, c)
+				p, err := kzg4844.ComputeBlobProof(&args.Blobs[i], c)
 				if err != nil {
 					return fmt.Errorf("blobs[%d]: error computing proof: %v", i, err)
 				}
 				proofs = append(proofs, p)
 			case types.BlobSidecarVersion1:
-				ps, err := kzg4844.ComputeCellProofs(&b)
+				ps, err := kzg4844.ComputeCellProofs(&args.Blobs[i])
 				if err != nil {
 					return fmt.Errorf("blobs[%d]: error computing proof: %v", i, err)
 				}
@@ -356,8 +356,8 @@ func (args *TransactionArgs) setBlobTxSidecar(ctx context.Context, config sideca
 	} else {
 		switch config.blobSidecarVersion {
 		case types.BlobSidecarVersion0:
-			for i, b := range args.Blobs {
-				if err := kzg4844.VerifyBlobProof(&b, args.Commitments[i], args.Proofs[i]); err != nil {
+			for i := range args.Blobs {
+				if err := kzg4844.VerifyBlobProof(&args.Blobs[i], args.Commitments[i], args.Proofs[i]); err != nil {
 					return fmt.Errorf("failed to verify blob proof: %v", err)
 				}
 			}
diff --git a/signer/core/apitypes/types.go b/signer/core/apitypes/types.go
index 9034e7e9ca0a..046bcc0bf539 100644
--- a/signer/core/apitypes/types.go
+++ b/signer/core/apitypes/types.go
@@ -246,13 +246,13 @@ func (args *SendTxArgs) validateTxSidecar() error {
 		// Generate commitment and proof.
 		commitments := make([]kzg4844.Commitment, n)
 		proofs := make([]kzg4844.Proof, n)
-		for i, b := range args.Blobs {
-			c, err := kzg4844.BlobToCommitment(&b)
+		for i := range args.Blobs {
+			c, err := kzg4844.BlobToCommitment(&args.Blobs[i])
 			if err != nil {
 				return fmt.Errorf("blobs[%d]: error computing commitment: %v", i, err)
 			}
 			commitments[i] = c
-			p, err := kzg4844.ComputeBlobProof(&b, c)
+			p, err := kzg4844.ComputeBlobProof(&args.Blobs[i], c)
 			if err != nil {
 				return fmt.Errorf("blobs[%d]: error computing proof: %v", i, err)
 			}
@@ -261,8 +261,8 @@ func (args *SendTxArgs) validateTxSidecar() error {
 		args.Commitments = commitments
 		args.Proofs = proofs
 	} else {
-		for i, b := range args.Blobs {
-			if err := kzg4844.VerifyBlobProof(&b, args.Commitments[i], args.Proofs[i]); err != nil {
+		for i := range args.Blobs {
+			if err := kzg4844.VerifyBlobProof(&args.Blobs[i], args.Commitments[i], args.Proofs[i]); err != nil {
 				return fmt.Errorf("failed to verify blob proof: %v", err)
 			}
 		}