core/types: reject blob tx sidecar in JSON#34989
Open
cuiweixie wants to merge 1 commit into
Open
Conversation
Contributor
|
The decoding of blob tx sidecar is intentionally left out of core/types JSON unmarshaling. The unmarshaling code is only used by ethclient and some other places, but we don't want blob sidecar to enter there. I guess it'd be good to change the decoder so it rejects the sidecar fields explicitly. |
cuiweixie
changed the title
cuiweixie
changed the title
Reject blob sidecar fields during transaction JSON unmarshalling because this decoder is not meant to import blob payloads.
cuiweixie
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
version,blobs,commitments,proofs) during transaction JSON unmarshalling.Test plan
go test ./core/types -run TestBlobTxJSONRejectsSidecargo test ./core/types