p2p/nat: use default route for nat-pmp gateway#35069
Open
jackg22 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/proc/net/routeX.X.X.1heuristic as a fallback and de-duplicate guessed gatewaysWhy
potentialGatewayscurrently assumes that a router lives at.1within each private IPv4 subnet. That works on many home networks, but it misses common setups where the default gateway uses another address such as.254. NAT-PMP discovery then probes the wrong host and fails even though a working gateway exists.This change makes Linux use the actual default route first, while preserving the current fallback behavior on other platforms and when route discovery is unavailable.
Validation
gofmt -w p2p/nat/natpmp.go p2p/nat/natpmp_gateway_linux.go p2p/nat/natpmp_gateway_linux_test.go p2p/nat/natpmp_gateway_other.gogo test ./p2p/natGOOS=linux GOARCH=amd64 go test -c ./p2p/nat