core: fix EIP-8037 double-refund of 7702 auth-base state gas within a tx#35128
Open
felix314159 wants to merge 1 commit into
Open
core: fix EIP-8037 double-refund of 7702 auth-base state gas within a tx#35128felix314159 wants to merge 1 commit into
felix314159 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if you take our bal 7.2.0 fixtures and then run
uv run consume direct --input fixtures/state_tests/for_amsterdam/prague/eip7702_set_code_tx/set_code_txs_2/ --bin ~/Documents/go-ethereum/build/bin/evm -k "double_auth and RESET and not first_delegation_DelegationTo.RESET"against geth's bal-devnet-7 evm, then you can see that both tests fail (other clients pass, and with this fix you also pass). lmk whether this fix makes sense, i discovered this via differential state fuzzing and then looked for an existing test that reproduces it