Minor refactor

Author: r0qs

Diff for: libsolidity/experimental/codegen/IRGeneratorForStatements.cpp

@@ -228,16 +228,16 @@ std::string IRGeneratorForStatements::buildFunctionCall(FunctionDefinition const
 	return output.str();
 }
 
-void IRGeneratorForStatements::declareAssign(IRVariable const& _lhs, IRVariable const& _rhs, bool _declare)
+void IRGeneratorForStatements::assign(IRVariable const& _lhs, IRVariable const& _rhs, bool _declare)
 {
 	solAssert(IRGeneratorForStatements::stackSize(m_context, _lhs.type()) == IRGeneratorForStatements::stackSize(m_context, _rhs.type()));
 	// TODO: conversions for abs and rep for user-defined types as no-ops
 	if (IRGeneratorForStatements::stackSize(m_context, _lhs.type()) == 1)
-		m_code << (_declare ? "let ": "") << _lhs.name() << " := " << _rhs.name() << "\n";
+		m_code << (_declare ? "let " : "") <<  _lhs.name() << " := " << _rhs.name() << "\n";
 	else
 	{
 		for (size_t i = 0; i < _lhs.stackSize(); ++i)
-			m_code << (_declare ? "let ": "") << _lhs.stackSlots()[i] << " := " << _rhs.stackSlots()[i] << "\n";
+			m_code << (_declare ? "let " : "") << _lhs.stackSlots()[i] << " := " << _rhs.stackSlots()[i] << "\n";
 	}
 }
 

Diff for: libsolidity/experimental/codegen/IRGeneratorForStatements.h

@@ -115,11 +115,10 @@ class IRGeneratorForStatements: public ASTConstVisitor
 	/// Default visit will reject all AST nodes that are not explicitly supported.
 	bool visitNode(ASTNode const& _node) override;
 
-	void declareAssign(IRVariable const& _var, IRVariable const& _value, bool _declare);
 	/// Defines @a _var using the value of @a _value. It declares and assign the variable.
-	void define(IRVariable const& _var, IRVariable const& _value) { declareAssign(_var, _value, true); }
+	void define(IRVariable const& _var, IRVariable const& _value) { assign(_var, _value, true); }
 	/// Assigns @a _var to the value of @a _value. It does not declare the variable.
-	void assign(IRVariable const& _var, IRVariable const& _value) { declareAssign(_var, _value, false); }
+	void assign(IRVariable const& _var, IRVariable const& _value, bool _declare = false);
 	/// Declares variable @a _var.
 	void declare(IRVariable const& _var);