Revert "Introduce via-ir option for syntax tests"

This reverts commit 35299b4.

Author: nikola-matic

Diff for: test/libsolidity/SyntaxTest.cpp

@@ -46,7 +46,6 @@ SyntaxTest::SyntaxTest(
 	m_minSeverity(_minSeverity)
 {
 	m_optimiseYul = m_reader.boolSetting("optimize-yul", true);
-	m_viaIr = m_reader.boolSetting("via-ir", false);
 }
 
 void SyntaxTest::setupCompiler(CompilerStack& _compiler)
@@ -59,7 +58,6 @@ void SyntaxTest::setupCompiler(CompilerStack& _compiler)
 		OptimiserSettings::full() :
 		OptimiserSettings::minimal()
 	);
-	_compiler.setViaIR(m_viaIr);
 	_compiler.setMetadataFormat(CompilerStack::MetadataFormat::NoMetadata);
 	_compiler.setMetadataHash(CompilerStack::MetadataHash::None);
 }
@@ -69,13 +67,13 @@ void SyntaxTest::parseAndAnalyze()
 	try
 	{
 		runFramework(withPreamble(m_sources.sources), PipelineStage::Compilation);
-		if (!pipelineSuccessful() && stageSuccessful(PipelineStage::Analysis))
+		if (!pipelineSuccessful() && stageSuccessful(PipelineStage::Analysis) && !compiler().isExperimentalAnalysis())
 		{
-			ErrorList const &errors = compiler().errors();
-			auto codeGeneretionErrorCount = count_if(errors.cbegin(), errors.cend(), [](auto const &error) {
+			ErrorList const& errors = compiler().errors();
+			auto codeGeneretionErrorCount = count_if(errors.cbegin(), errors.cend(), [](auto const& error) {
 				return error->type() == Error::Type::CodeGenerationError;
 			});
-			auto errorCount = count_if(errors.cbegin(), errors.cend(), [](auto const &error) {
+			auto errorCount = count_if(errors.cbegin(), errors.cend(), [](auto const& error) {
 				return Error::isError(error->type());
 			});
 			// failing compilation after successful analysis is a rare case,

Diff for: test/libsolidity/SyntaxTest.h

@@ -53,7 +53,6 @@ class SyntaxTest: public AnalysisFramework, public solidity::test::CommonSyntaxT
 	virtual void filterObtainedErrors();
 
 	bool m_optimiseYul{};
-	bool m_viaIr{};
 	langutil::Error::Severity m_minSeverity{};
 };
 

Diff for: test/libsolidity/syntaxTests/experimental/builtin/builtin_type_definition.sol

@@ -31,7 +31,6 @@ contract C {
 }
 // ====
 // EVMVersion: >=constantinople
-// via-ir: true
 // ----
 // Warning 2264: (0-29): Experimental features are turned on. Do not use experimental features on live deployments.
 // Info 4164: (31-61): Inferred type: void

Diff for: test/libsolidity/syntaxTests/experimental/builtin/builtin_type_definition_duplicate.sol

@@ -10,7 +10,6 @@ type fun1(T, U) = __builtin("fun");
 type fun2(T, U) = __builtin("fun");
 // ====
 // EVMVersion: >=constantinople
-// via-ir: true
 // ----
 // Warning 2264: (0-29): Experimental features are turned on. Do not use experimental features on live deployments.
 // TypeError 9609: (63-94): Duplicate builtin type definition.

Diff for: test/libsolidity/syntaxTests/experimental/builtin/builtin_type_definition_unknown.sol

@@ -3,7 +3,6 @@ pragma experimental solidity;
 type someUnknownType = __builtin("someUnknownType");
 // ====
 // EVMVersion: >=constantinople
-// via-ir: true
 // ----
 // Warning 2264: (0-29): Experimental features are turned on. Do not use experimental features on live deployments.
 // TypeError 7758: (31-81): Expected the name of a built-in primitive type.

Diff for: test/libsolidity/syntaxTests/experimental/import/experimental_solidity.sol

@@ -1,6 +1,5 @@
 pragma experimental solidity;
 // ====
 // EVMVersion: >=constantinople
-// via-ir: true
 // ----
 // Warning 2264: (0-29): Experimental features are turned on. Do not use experimental features on live deployments.

Diff for: test/libsolidity/syntaxTests/experimental/import/parsing_stdlib_import_1.sol

@@ -3,7 +3,6 @@ pragma experimental solidity;
 import std.stub;
 // ====
 // EVMVersion: >=constantinople
-// via-ir: true
 // ----
 // Warning 2264: (std.stub:63-92): Experimental features are turned on. Do not use experimental features on live deployments.
 // Warning 2264: (0-29): Experimental features are turned on. Do not use experimental features on live deployments.

Diff for: test/libsolidity/syntaxTests/experimental/import/parsing_stdlib_import_2.sol

@@ -3,7 +3,6 @@ pragma experimental solidity;
 import std.stub as stub;
 // ====
 // EVMVersion: >=constantinople
-// via-ir: true
 // ----
 // Warning 2264: (std.stub:63-92): Experimental features are turned on. Do not use experimental features on live deployments.
 // Warning 2264: (0-29): Experimental features are turned on. Do not use experimental features on live deployments.

Diff for: test/libsolidity/syntaxTests/experimental/import/parsing_stdlib_import_3.sol

@@ -3,7 +3,6 @@ pragma experimental solidity;
 import { identity } from std.stub;
 // ====
 // EVMVersion: >=constantinople
-// via-ir: true
 // ----
 // Warning 2264: (std.stub:63-92): Experimental features are turned on. Do not use experimental features on live deployments.
 // Warning 2264: (0-29): Experimental features are turned on. Do not use experimental features on live deployments.

Diff for: test/libsolidity/syntaxTests/experimental/import/parsing_stdlib_import_4.sol

@@ -3,7 +3,6 @@ pragma experimental solidity;
 import * as stub from std.stub;
 // ====
 // EVMVersion: >=constantinople
-// via-ir: true
 // ----
 // Warning 2264: (std.stub:63-92): Experimental features are turned on. Do not use experimental features on live deployments.
 // Warning 2264: (0-29): Experimental features are turned on. Do not use experimental features on live deployments.

Diff for: test/libsolidity/syntaxTests/experimental/inference/import_and_call_stdlib_function.sol

@@ -12,7 +12,6 @@ contract C
 
 // ====
 // EVMVersion: >=constantinople
-// via-ir: true
 // ----
 // Warning 2264: (std.stub:63-92): Experimental features are turned on. Do not use experimental features on live deployments.
 // Warning 2264: (0-29): Experimental features are turned on. Do not use experimental features on live deployments.