ICE when loading the same file multiple times via import callback

[cameel]

Description

When the same path is specified under urls of multiple contracts in Standard JSON input, we get an ICE in the import callback.

Environment

• Compiler version: 0.8.27

Steps to Reproduce

input.json:

{
    "language": "Solidity",
    "sources": {
        "A": {"urls": ["/tmp/test.sol"]},
        "B": {"urls": ["/tmp/test.sol"]}
    }
}

/tmp/test.sol

// SPDX-License-Identifier: MIT
pragma solidity *;

contract C {}

solc --standard-json input.json --pretty-json --json-indent 4

Output:

{
    "errors": [
        {
            "component": "general",
            "formattedMessage": "Cannot import url (\"/tmp/test.sol\"): Exception in read callback: /solidity/libsolidity/interface/FileReader.cpp(164): Throw in function solidity::frontend::ReadCallback::Result solidity::frontend::FileReader::readFile(const std::string&, const std::string&)\nDynamic exception type: boost::wrapexcept<solidity::langutil::InternalCompilerError>\nstd::exception::what: Solidity assertion failed\n[solidity::util::tag_comment*] = Solidity assertion failed\n",
            "message": "Cannot import url (\"/tmp/test.sol\"): Exception in read callback: /solidity/libsolidity/interface/FileReader.cpp(164): Throw in function solidity::frontend::ReadCallback::Result solidity::frontend::FileReader::readFile(const std::string&, const std::string&)\nDynamic exception type: boost::wrapexcept<solidity::langutil::InternalCompilerError>\nstd::exception::what: Solidity assertion failed\n[solidity::util::tag_comment*] = Solidity assertion failed\n",
            "severity": "error",
            "type": "IOError"
        }
    ],
    "sources": {
        "A": {
            "id": 0
        }
    }
}

[cameel]

The immediate cause is that the callback has this weird flow, where the sources are not stored in a single place, but independently in both FileReader and CompilerStack. We initially fill the FileReader, then pass the sources into CompilerStack, which may add new ones loaded by the callback, but the reader still exists and updates its m_sourceCodes map:

solidity/libsolidity/interface/FileReader.cpp

Lines 163 to 165 in 3ee5f2d

	solAssert(m_sourceCodes.count(_sourceUnitName) == 0, "");
	m_sourceCodes[_sourceUnitName] = contents;
	return ReadCallback::Result{true, contents};

We should get rid of that. It would be best to separate the storage of the sources from the callback. The callback should know its settings but be stateless otherwise.

[gks2022004]

@cameel please assign it to me