Skip to content

Running syntax tests via IR #15670

Open
Open
@cameel

Description

@cameel

Abstract

Currently our syntax tests get compiled only using the legacy codegen. We should either switch to compiling via IR or compile using both.

Motivation

Compiling via IR would increase test coverage and and bugs like #15669 show that we really need that.

This was also originally an issue for EOF implementation because it only works via IR.

Note that this is likely going to significantly increase the test running time.

Specification

We already have compileViaYul flag in syntax tests:

m_compileViaYul = m_reader.stringSetting("compileViaYul", "false");

The solution would be to either switch the default to true or start supporting also like in semantic tests to compile both ways (and make it the default). Then fix any issues that come up in the tests.

Metadata

Metadata

Assignees

No one assigned

    Labels

    low impactChanges are not very noticeable or potential benefits are limited.medium effortDefault level of effortmust have eventuallySomething we consider essential but not enough to prevent us from releasing Solidity 1.0 without it.testing 🔨

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions