Skip to content

Fix opening comment marker in license header of some files #15940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2025

Conversation

sky-coderay
Copy link
Contributor

libyul/optimiser/CommonSubexpressionEliminator.cpp
libyul/optimiser/DataFlowAnalyzer.cpp

/*( -deleted (

Copy link

Thank you for your contribution to the Solidity compiler! A team member will follow up shortly.

If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother.

If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix.

@clonker
Copy link
Member

clonker commented Mar 14, 2025

Thank you for your contribution :) there are a couple more of these hiding throughout the codebase. Could you fix them all and bundle it all up in one single commit?

@matheusaaguiar
Copy link
Collaborator

Hey @sky-coderay , I found these other places where we could also fix and bundle everything together.
Are you up for finishing that?

libyul/CompilabilityChecker.cpp:/*(
libyul/optimiser/SyntacticalEquality.cpp:/*(
libyul/optimiser/StackCompressor.cpp:/*(
libyul/optimiser/UnusedPruner.cpp:/*(
libyul/optimiser/Rematerialiser.cpp:/*(
libyul/optimiser/Metrics.cpp:/*(
libyul/optimiser/DataFlowAnalyzer.cpp:/*(
libyul/optimiser/CommonSubexpressionEliminator.cpp:/*(

@sky-coderay
Copy link
Contributor Author

Yes , sure

@sky-coderay
Copy link
Contributor Author

@matheusaaguiar ready , thanks

@cameel cameel changed the title [easy] fix minor issues Fix openning comment marker in license header of some files Apr 17, 2025
@cameel cameel changed the title Fix openning comment marker in license header of some files Fix opening comment marker in license header of some files Apr 17, 2025
Update DataFlowAnalyzer.cpp

Update CommonSubexpressionEliminator.cpp

/*( -deleted (
@matheusaaguiar matheusaaguiar merged commit 8cf3305 into ethereum:develop Apr 17, 2025
74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants