Introduce universal compilation host to execution framework #15960
Conversation
|
Thank you for your contribution to the Solidity compiler! A team member will follow up shortly. If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother. If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix. |
erak
force-pushed
the
test-compiler-host
branch
from
08ce0db to
9387714
Compare
erak
force-pushed
the
test-compiler-host
branch
3 times, most recently
from
6a47a21 to
9e50f8c
Compare
|
There was an error when running Please check that your changes are working as intended. |
erak
force-pushed
the
test-compiler-host
branch
from
f79fbae to
3b47946
Compare
erak
force-pushed
the
test-compiler-host
branch
3 times, most recently
from
9e5df30 to
eb50f43
Compare
erak
changed the title
erak
force-pushed
the
test-compiler-host
branch
from
eb50f43 to
132c6f4
Compare
There was a problem hiding this comment.
Some things need to be ironed out still, on a small scale you should make a pass over the PR and fix all the autos to use auto const& and auto const* where appropriate. Or respective mutable reference/pointer types. Or nothing, if you explicitly want to make a copy :)
Also (but optionally), I personally like to make as much const as possible. For ex., if you have a bool shouldDoSomething = m_compiler.shouldDoSomething() will the sole purpose to pass it on and not modify it further, I declare it as bool const shouldDoSomething = ....
On the bigger scale of things, I am not a big fan of these optionals everywhere to capture experimental solidity in which some data members aren't available. It leads to a lot of bloat. Perhaps a variant with two clean distinct structs would be better. But not sure, really.
erak
force-pushed
the
test-compiler-host
branch
from
132c6f4 to
fe072fc
Compare
| std::string const& _sourceName | ||
| ) const | ||
| { | ||
| solAssert(m_sources.find(_sourceName) != m_sources.end(), "No source found."); |
| solAssert(m_sources.find(_sourceName) != m_sources.end(), "No source found."); | ||
| auto const& source = m_sources.find(_sourceName); | ||
|
|
||
| return ASTNode::filteredNodes<ContractDefinition>(source->second.ast->nodes()); |
Description
This PR implements a universal compiler host for running tests with various compilers (etc. the internal compiler aka.
CompilerStackor standard JSON compiler).Details
It introduces some common types for the compiler inputs and its output. A compilation module that wraps the linked / internal compiler was added. It can be used in a newly added universal compiler host. This host is then used inside the test execution framework.
Outlook
The input / output types introduced by this PR were inspired by the
SolidityCompilationFramework. In a future PR the universal compiler host could be used there as well.Ultimately, this PR makes it possible to implement a compilation module for the standard JSON compiler as well and use that in the pipeline.