Description
Now that there are more audited versions of the staking-deposit-cli, it is time to rethink how we do ensure that the deposit_data.json
was generated by a tool with sufficient features.
Currently, we use the REACT_APP_MIN_DEPOSIT_CLI_VERSION
constant to ensure a minimum feature set, but this is awkwardly tied to the https://github.com/ethereum/staking-deposit-cli which noi longer seems appropriate.
One approach would be to have text-based features we add to ensure a minimum level of support and check for those (eg. testnet-holesky, bug-fix-123
), but this feels a little over engineered for our current needs.
Personally I am partial to sticking with the numbering approach, but just agreeing with the ethstaker folks as to when we need to bump the version number. We could even maintain a doc in this repo that maps features to version numbers.
cc @remyroy @valefar-on-discord I'd love to hear your thoughts here.