suggested edits

Author: 0xthrpw

.github/workflows/ai-on-demand.yaml

@@ -1,4 +1,5 @@
 name: AI On-Demand Assistant
+description: "Provides AI assistance when @efp-dev-ops is mentioned by authorized users"
 on:
   issue_comment:
     types: [created]
@@ -18,21 +19,18 @@ jobs:
         (github.event_name == 'pull_request_review_comment' && contains(github.event.comment.body, '@efp-dev-ops')) ||
         (github.event_name == 'pull_request_review' && contains(github.event.review.body, '@efp-dev-ops')) ||
         (github.event_name == 'issues' && contains(github.event.issue.body, '@efp-dev-ops'))
-      ) && (
-        github.actor == '0xthrpw' ||
-        github.actor == 'encrypteddegen' ||
-        github.actor == 'caveman-eth' ||
-        github.actor == 'brantlymillegan'
-      ) 
+      ) && contains(fromJSON(vars.ALLOWED_USER_LIST), github.actor) 
     runs-on: ubuntu-latest
     permissions:
       contents: read
       issues: write
       pull-requests: write
 
     steps:
-    - name: Checkout code
+    - name: Checkout Code
       uses: actions/checkout@v4
+      with:
+        fetch-depth: 1
 
     - name: Generate Custom App Token
       id: generate-token
@@ -41,7 +39,7 @@ jobs:
         app-id: ${{ secrets.APP_ID }}
         private-key: ${{ secrets.PRIVATE_KEY }}
 
-    - name: Extract instruction from comment
+    - name: Extract Instruction from Comment
       id: extract-instruction
       run: |
         # Get the comment body based on event type
@@ -60,6 +58,12 @@ jobs:
         # Remove the @mention and get the instruction
         INSTRUCTION=$(echo "$COMMENT_BODY" | sed 's/@efp-dev-ops[[:space:]]*//' | sed 's/^[[:space:]]*//')
         
+        # Add input validation
+        if [ ${#INSTRUCTION} -gt 4000 ]; then
+          echo "Instruction too long, truncating..."
+          INSTRUCTION=$(echo "$INSTRUCTION" | head -c 4000)
+        fi
+        
         # Set as output for next step
         echo "instruction<<EOF" >> $GITHUB_OUTPUT
         echo "$INSTRUCTION" >> $GITHUB_OUTPUT
@@ -69,6 +73,8 @@ jobs:
     
     - name: AI Response
       uses: anthropics/claude-code-action@v0
+      continue-on-error: true
+      timeout-minutes: 10
       with:
         # anthropic_api_key: ${{ secrets.ANTHROPIC_API_KEY }}
         claude_code_oauth_token: ${{ secrets.CLAUDE_CODE_OAUTH_TOKEN }}
@@ -81,22 +87,3 @@ jobs:
           Please provide a helpful, accurate response. If the request involves code analysis, focus on the current repository context. If it's a general question, provide clear and actionable guidance.
           
           Keep your response concise but thorough, and format it nicely for GitHub comments.
-    
-    # - name: React to original comment
-    #   run: |
-    #     # Add a reaction to show the app "saw" the mention
-    #     if [ "${{ github.event_name }}" = "issue_comment" ] || [ "${{ github.event_name }}" = "pull_request_review_comment" ]; then
-    #       gh api repos/${{ github.repository }}/issues/comments/${{ github.event.comment.id }}/reactions \
-    #         --method POST \
-    #         --field content="+1"
-    #     elif [ "${{ github.event_name }}" = "pull_request_review" ]; then
-    #       gh api repos/${{ github.repository }}/pulls/${{ github.event.pull_request.number }}/reviews/${{ github.event.review.id }}/reactions \
-    #         --method POST \
-    #         --field content="+1"
-    #     elif [ "${{ github.event_name }}" = "issues" ]; then
-    #       gh api repos/${{ github.repository }}/issues/${{ github.event.issue.number }}/reactions \
-    #         --method POST \
-    #         --field content="+1"
-    #     fi
-      env:
-        GITHUB_TOKEN: ${{ steps.generate-token.outputs.token }}

.github/workflows/ai-review.yaml

@@ -1,4 +1,5 @@
 name: Custom AI Code Review
+description: "Automated code quality and documentation review on pull requests"
 on:
   pull_request:
     types: [opened, synchronize, reopened]
@@ -14,7 +15,7 @@ jobs:
       issues: write
 
     steps:
-    - name: Checkout code
+    - name: Checkout Code
       uses: actions/checkout@v4
       with:
         fetch-depth: 0  # Get full history for better context
@@ -26,31 +27,10 @@ jobs:
         app-id: ${{ secrets.APP_ID }}
         private-key: ${{ secrets.PRIVATE_KEY }}
 
-    # - name: AI Security Review
-    #   uses: anthropics/claude-code-action@v0
-    #   with:
-    #     # anthropic_api_key: ${{ secrets.ANTHROPIC_API_KEY }}
-    #     claude_code_oauth_token: ${{ secrets.CLAUDE_CODE_OAUTH_TOKEN }}
-    #     github_token: ${{ steps.generate-token.outputs.token }}
-    #     direct_prompt: |
-    #       You are the AI security reviewer for our organization.
-          
-    #       Please analyze this pull request for:
-    #       🛡️ **Security Vulnerabilities**
-    #       - SQL injection risks
-    #       - XSS vulnerabilities  
-    #       - Authentication/authorization issues
-    #       - Input validation problems
-          
-    #       📋 **Compliance Check**
-    #       - Follows our security coding standards
-    #       - Proper error handling
-    #       - Secure configuration practices
-          
-    #       Please provide specific, actionable feedback with line numbers where applicable.
-    
     - name: AI Code Quality Review
       uses: anthropics/claude-code-action@v0
+      continue-on-error: true
+      timeout-minutes: 10
       with:
         # anthropic_api_key: ${{ secrets.ANTHROPIC_API_KEY }}
         claude_code_oauth_token: ${{ secrets.CLAUDE_CODE_OAUTH_TOKEN }}
@@ -79,6 +59,7 @@ jobs:
           Format your response as a professional code review.
     
     - name: Post Summary Comment
+      continue-on-error: true
       run: |
         gh pr comment ${{ github.event.number }} --body "
         ## 🤖 AI Code Review Complete