Add Unified EL metrics for GetBlobsV2

Author: SunnysidedJ

packages/client/src/rpc/modules/engine/engine.ts

@@ -63,6 +63,7 @@ import {
   payloadAttributesFieldValidatorsV3,
 } from './validators.ts'
 
+import { blob } from 'node:stream/consumers'
 import type { Block, ExecutionPayload } from '@ethereumjs/block'
 import type { PrefixedHexString } from '@ethereumjs/util'
 import type { VM } from '@ethereumjs/vm'
@@ -1545,15 +1546,28 @@ export class Engine {
       }
     }
 
+    let blobsInPool = 0
+    let blobMissed = false
     const blobAndProofsArr: BlobAndProofV2[] = []
     for (const versionedHashHex of params[0]) {
       const blobAndProofs = this.service.txPool.blobAndProofsByHash.get(versionedHashHex)
       if (blobAndProofs === undefined) {
-        return null
+        blobMissed = true
+      } else {
+        blobsInPool++
+        blobAndProofsArr.push(blobAndProofs)
       }
-      blobAndProofsArr.push(blobAndProofs)
     }
 
+    this.config.metrics?.blobEIP7594ReqTotalGauge.inc(params[0].length)
+    this.config.metrics?.blobEIP7594ReqTotalInPoolGauge.inc(blobsInPool)
+
+    if (blobMissed) {
+      this.config.metrics?.blobEIP7594PoolMissGauge.inc()
+      return null
+    }
+
+    this.config.metrics?.blobEIP7594PoolHitGauge.inc()
     return blobAndProofsArr
   }
 }

packages/client/src/types.ts

@@ -156,4 +156,8 @@ export type PrometheusMetrics = {
   feeMarketEIP1559TxGauge: promClient.Gauge<string>
   blobEIP4844TxGauge: promClient.Gauge<string>
   blobEIP7594TxGauge: promClient.Gauge<string>
+  blobEIP7594ReqTotalGauge: promClient.Gauge<string>
+  blobEIP7594ReqTotalInPoolGauge: promClient.Gauge<string>
+  blobEIP7594PoolHitGauge: promClient.Gauge<string>
+  blobEIP7594PoolMissGauge: promClient.Gauge<string>
 }

packages/client/src/util/metrics.ts

@@ -22,5 +22,21 @@ export const setupMetrics = () => {
       name: 'blob_eip_7594_transactions_in_transaction_pool',
       help: 'Number of blob EIP 7594 transactions in the client transaction pool',
     }),
+    blobEIP7594ReqTotalGauge: new promClient.Gauge({
+      name: 'get_blobs_requests_blobs_total',
+      help: 'Number of blobs requested via GetBlobsV2',
+    }),
+    blobEIP7594ReqTotalInPoolGauge: new promClient.Gauge({
+      name: 'get_blobs_requests_blobs_in_blobpool_total',
+      help: 'Number of blobs requested via GetBlobsV2 that are present in the blobpool',
+    }),
+    blobEIP7594PoolHitGauge: new promClient.Gauge({
+      name: 'get_blobs_requests_success_total',
+      help: 'Number of times GetBlobsV2 responded with a success/hit',
+    }),
+    blobEIP7594PoolMissGauge: new promClient.Gauge({
+      name: 'get_blobs_requests_failure_total',
+      help: 'Number of times GetBlobsV2 responded with a failure/miss',
+    }),
   }
 }

packages/client/test/sync/txpool.spec.ts

@@ -65,6 +65,22 @@ const setup = () => {
         name: 'blob_eip_7594_transactions_in_transaction_pool',
         help: 'Number of blob EIP 4844 transactions in the client transaction pool',
       }),
+      blobEIP7594ReqTotalGauge: new promClient.Gauge({
+        name: 'get_blobs_requests_blobs_total',
+        help: 'Number of blobs requested via GetBlobsV2',
+      }),
+      blobEIP7594ReqTotalInPoolGauge: new promClient.Gauge({
+        name: 'get_blobs_requests_blobs_in_blobpool_total',
+        help: 'Number of blobs requested via GetBlobsV2 that are present in the blobpool',
+      }),
+      blobEIP7594PoolHitGauge: new promClient.Gauge({
+        name: 'get_blobs_requests_success_total',
+        help: 'Number of times GetBlobsV2 responded with a success/hit',
+      }),
+      blobEIP7594PoolMissGauge: new promClient.Gauge({
+        name: 'get_blobs_requests_failure_total',
+        help: 'Number of times GetBlobsV2 responded with a failure/miss',
+      }),
     }
 
     const register = new promClient.Registry()