Skip to content

Util: Remove signature module in favor of direct ethereum-cryptography usage (needs analysis) #1845

Open
@holgerd77

Description

@holgerd77

Similar to #1844 the signature functionality is now also provided by ethereum-cryptography.

Particularly for current state (so: typed, e.g. EIP-2930 txs) tx signature handling this functionality can be used very much directly, which becomes the very prevalent use case.

It should therfore be analyzed (and then executed upon) if the signature module can also be removed from Util in favor of a direct usage. One way to deal with the remaining legacy EIP-155 code in the signature module would be to encapsulate this code in the legacy tx class being the only remaining consumer (would need some confirmation).

Note that this issue should bre handled with special care due to the sensitive nature of the signature functionality.

Main functionality is contained in ecsign() and ecrecover().

These functions are - beside tx - also used in:

  • ecsign(): Block Header Clique Functionality
  • ecrecover(): Block Header Clique Functionality
  • ecrecover(): VM precompile

Not sure if I missed something. Also not sure yet if or if not legacy signing functionality is used in some of these and how these usages would be handled on a direct ethereum-cryptography usage.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions