fix(vm): rollback builder state on failed Osaka blob tx (Fixes issue #4271)#4290
Open
rame3519 wants to merge 1 commit into
Open
fix(vm): rollback builder state on failed Osaka blob tx (Fixes issue #4271)#4290rame3519 wants to merge 1 commit into
rame3519 wants to merge 1 commit into
Conversation
Member
|
Hi there, thanks for the PR. What is your motivation to fix this? |
Author
Hello! Thanks for reaching out to me. This fix was for my Blockchains & Cryptocurrencies group project which required us to fix a related git project issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes a non-atomic failure path in
BlockBuilder.addTransaction()where malformed Osaka blob transactions could partially mutate builder state before post-run validation failed.Problem:
A Prague-created blob tx wrapped as an EIP-7594 network wrapper could:
runTx()blobGasUsedcreateMinimal4844TxFromNetworkWrapper()This left the builder in a poisoned state despite the transaction being rejected.
Fix:
runTx()Validation:
Added regression test:
ethjs-osaka-builder-state-poison.spec.tsBefore fix:
After fix: