-
-
Notifications
You must be signed in to change notification settings - Fork 2k
Open
Labels
enhancementNew feature or improvement.New feature or improvement.minor-bumpPlanned for the next minor version bump.Planned for the next minor version bump.on-deckThis Enhancement or Bug is currently being worked on.This Enhancement or Bug is currently being worked on.v6Issues regarding v6Issues regarding v6
Description
Ethers Version
6
Describe the Problem
The default deduping timeout of 250ms
could be dangerous as it could lead to mempool state sync issues, that can consequently lead to failure of actions (e.g. if a consumer depends on a eth_getTxCount(..., "pending")
or other blockchain state that depends on the mempool/"pending"
.
I would recommend for the deduping timeout to be opt-in, or to disable this for block tags.
https://github.com/ethers-io/ethers.js/blob/main/src.ts/providers/abstract-provider.ts#L427
Metadata
Metadata
Assignees
Labels
enhancementNew feature or improvement.New feature or improvement.minor-bumpPlanned for the next minor version bump.Planned for the next minor version bump.on-deckThis Enhancement or Bug is currently being worked on.This Enhancement or Bug is currently being worked on.v6Issues regarding v6Issues regarding v6