fix nil pointer panic in check_consensus_block_proposals task

Author: pk910

pkg/coordinator/tasks/check_consensus_block_proposals/task.go

@@ -644,9 +644,9 @@ func (t *Task) checkBlockWithdrawals(block *consensus.Block, blockData *spec.Ver
 					switch {
 					case expectedWithdrawal.Address != "" && !strings.EqualFold(expectedWithdrawal.Address, withdrawal.Address.String()):
 						t.logger.Warnf("check failed: withdrawal found, but execution address does not match (have: %v, want: %v)", withdrawal.Address.String(), expectedWithdrawal.Address)
-					case expectedWithdrawal.MinAmount.Cmp(big.NewInt(0)) > 0 && expectedWithdrawal.MinAmount.Cmp(withdrawalAmount) > 0:
+					case expectedWithdrawal.MinAmount != nil && expectedWithdrawal.MinAmount.Cmp(big.NewInt(0)) > 0 && expectedWithdrawal.MinAmount.Cmp(withdrawalAmount) > 0:
 						t.logger.Warnf("check failed: withdrawal found, but amount lower than minimum (have: %v, want >= %v)", withdrawalAmount, expectedWithdrawal.MinAmount)
-					case expectedWithdrawal.MaxAmount.Cmp(big.NewInt(0)) > 0 && expectedWithdrawal.MaxAmount.Cmp(withdrawalAmount) < 0:
+					case expectedWithdrawal.MaxAmount != nil && expectedWithdrawal.MaxAmount.Cmp(big.NewInt(0)) > 0 && expectedWithdrawal.MaxAmount.Cmp(withdrawalAmount) < 0:
 						t.logger.Warnf("check failed: withdrawal found, but amount higher than maximum (have: %v, want <= %v)", withdrawalAmount, expectedWithdrawal.MaxAmount)
 					default:
 						found = true

playbooks/pectra-dev/eip7251-all.yaml

@@ -26,22 +26,6 @@ tasks:
     minEpochNumber: "tasks.get_specs.outputs.specs.ELECTRA_FORK_EPOCH"
 
 # prepare wallets
-- name: get_random_mnemonic
-  id: test_mnemonic
-  title: "Generate random mnemonic"
-  if: "useExistingValidators == false"
-
-- name: run_shell
-  title: "Use generated random mnemonic for tests"
-  if: "useExistingValidators == false"
-  config:
-    envVars:
-      MNEMONIC: "tasks.test_mnemonic.outputs.mnemonic"
-    command: |
-      # override the validatorMnemonic variable with the generated random mnemonic
-      echo "::set-var validatorMnemonic ${MNEMONIC}"
-      echo "::set-json validatorStartIndex 0"
-
 - name: generate_child_wallet
   id: main_wallet
   title: "Generate main wallet for tests"
@@ -67,6 +51,20 @@ tasks:
   config:
     stopChildOnResult: false
     tasks:
+    # generate random mnemonic
+    - name: get_random_mnemonic
+      id: test_mnemonic
+      title: "Generate random mnemonic"
+    - name: run_shell
+      title: "Use generated random mnemonic for tests"
+      config:
+        envVars:
+          MNEMONIC: "tasks.test_mnemonic.outputs.mnemonic"
+        command: |
+          # override the validatorMnemonic variable with the generated random mnemonic
+          echo "::set-json validatorMnemonic ${MNEMONIC}"
+          echo "::set-json validatorStartIndex 0"
+
     # generate 22 deposits with 0x00 withdrawal credentials
     - name: generate_deposits
       id: deposits
@@ -503,6 +501,7 @@ tasks:
           config:
             validatorStatus:
             - active_ongoing
+            minValidatorBalance: 2047100000000 # expect >2047.1 ETH
             maxValidatorBalance: 2048100000000 # expect <2048.1 ETH
           configVars:
             validatorPubKey: "tasks.validator_pubkeys.outputs.pubkeys[4]"
@@ -1196,7 +1195,7 @@ tasks:
           title: "Check if key 14 has received the full balance"
           timeout: 8h
           config:
-            minValidatorBalance: 95900000000 # expect >95.9 ETH
+            minValidatorBalance: 95700000000 # expect >95.7 ETH
             validatorStatus:
             - active_ongoing
           configVars:

playbooks/pectra-dev/validator-lifecycle-test-v3.yaml

@@ -115,9 +115,9 @@ tasks:
         depositContract: "depositContract"
         withdrawalCredentials: "| \"0x010000000000000000000000\" + (.tasks.depositor_wallet.outputs.childWallet.address | capture(\"(0x)?(?<addr>.+)\").addr)"
 
-    # 1 deposit, 24 ETH, 0x01 withdrawal creds (index 7)
+    # 1 deposit, 24 ETH, 0x02 withdrawal creds (index 7)
     - name: generate_deposits
-      title: "Generate 1 deposit with 24 ETH and 0x01 withdrawal creds (index 7)"
+      title: "Generate 1 deposit with 24 ETH and 0x02 withdrawal creds (index 7)"
       id: deposit_3
       config:
         limitTotal: 1
@@ -129,7 +129,7 @@ tasks:
         walletPrivkey: "tasks.depositor_wallet.outputs.childWallet.privkey"
         mnemonic: "tasks.test_mnemonic.outputs.mnemonic"
         depositContract: "depositContract"
-        withdrawalCredentials: "| \"0x010000000000000000000000\" + (.tasks.depositor_wallet.outputs.childWallet.address | capture(\"(0x)?(?<addr>.+)\").addr)"
+        withdrawalCredentials: "| \"0x020000000000000000000000\" + (.tasks.depositor_wallet.outputs.childWallet.address | capture(\"(0x)?(?<addr>.+)\").addr)"
 
     # 2 deposits, 64 ETH each, 0x02 withdrawal creds (index 8-9)
     - name: generate_deposits
@@ -587,6 +587,34 @@ tasks:
   config:
     tasks:
 
+    # generate self consolidation for key 5 & wait for inclusion
+    - name: run_task_background
+      title: "Generate self consolidation for key 5"
+      timeout: 10m
+      config:
+        onBackgroundComplete: failOrIgnore
+        backgroundTask:
+          name: generate_consolidations
+          title: "Generate 1 self consolidation (key 5)"
+          config:
+            limitTotal: 1
+            sourceStartIndex: 5
+            sourceIndexCount: 1
+            awaitReceipt: true
+            failOnReject: true
+          configVars:
+            sourceMnemonic: "tasks.test_mnemonic.outputs.mnemonic"
+            targetPublicKey: "tasks.all_pubkeys.outputs.pubkeys[5]"
+            walletPrivkey: "tasks.depositor_wallet.outputs.childWallet.privkey"
+        
+        foregroundTask:
+          name: check_consensus_block_proposals
+          title: "Wait for inclusion of self consolidation request for key 5"
+          config:
+            minConsolidationRequestCount: 1
+          configVars:
+            expectConsolidationRequests: "| [{sourceAddress: .tasks.depositor_wallet.outputs.childWallet.address, sourcePubkey: .tasks.all_pubkeys.outputs.pubkeys[5]}]"
+
     - name: run_task_background
       title: "Generate consolidations & track inclusion"
       config: