Skip to content

feat(ethrex): set default --http.api namespaces#1392

Merged
barnabasbusa merged 5 commits into
mainfrom
bbusa/ethrex-default-http-api
May 18, 2026
Merged

feat(ethrex): set default --http.api namespaces#1392
barnabasbusa merged 5 commits into
mainfrom
bbusa/ethrex-default-http-api

Conversation

@barnabasbusa
Copy link
Copy Markdown
Collaborator

@barnabasbusa barnabasbusa commented May 14, 2026

Waiting on ethrex team's approval when to merge this.

Summary

  • Add --http.api=eth,net,web3,debug,admin,txpool to the ethrex launcher's default cmd so HTTP RPC exposes the same namespace set we already enable for the other EL clients (geth/reth/besu/erigon/nethermind).

Test plan

  • Spin up a devnet with el_type: ethrex and confirm eth_*, net_*, web3_*, debug_*, admin_*, and txpool_* JSON-RPC methods respond over HTTP.

Match the other EL launchers by enabling eth, net, web3, debug, admin,
and txpool over HTTP by default for ethrex.
@barnabasbusa barnabasbusa added the DO-NOT-MERGE Do not merge this PR label May 14, 2026
@edg-l
Copy link
Copy Markdown

edg-l commented May 15, 2026

LGTM

@barnabasbusa barnabasbusa enabled auto-merge (squash) May 18, 2026 12:23
@barnabasbusa barnabasbusa removed the DO-NOT-MERGE Do not merge this PR label May 18, 2026
@barnabasbusa
Copy link
Copy Markdown
Collaborator Author

Should revert default image once a new release is made

@qu0b-reviewer
Copy link
Copy Markdown

qu0b-reviewer Bot commented May 18, 2026

🤖 qu0b-reviewer

Looks good — minimal diff (one line), no concerns. The addition aligns with the pattern established by reth_launcher.star (no engine namespace, since ethrex also uses --authrpc on a separate port for the CL↔EL Engine API). 🚀


Reviewed @ 56eb4ede
"Backups are useless. Restores are everything."

@barnabasbusa barnabasbusa merged commit cb83373 into main May 18, 2026
16 checks passed
@barnabasbusa barnabasbusa deleted the bbusa/ethrex-default-http-api branch May 18, 2026 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants