feat(grafana): support http dashboard URLs

[fjl]

Makes it so I can do this

grafana_params:
  additional_dashboards:
    - "https://gist.githubusercontent.com/fjl/xxx/raw/xxx/dashboard.json"

[cskiraly]

Nice feature, I missed it

[barnabasbusa]

nit / suggestion: this repo already has the curl-via-run_sh + StoreSpec pattern for fetching remote files (see src/network_launcher/ephemery.star, shadowfork.star, public_network.star). Using it here drops the embedded Python and matches the rest of the codebase.

Locally tested with a raw.githubusercontent.com URL — artifact lands in grafana's /dashboards/ correctly.

Suggested change

	result = plan.run_python(
	description = "Downloading Grafana dashboard: {0}".format(url),
	run = """
	import sys, urllib.request, os
	os.makedirs("/dashboards-dl", exist_ok=True)
	urllib.request.urlretrieve(sys.argv[1], "/dashboards-dl/" + sys.argv[2])
	""",
	args = [url, name],
	store = [StoreSpec(src = "/dashboards-dl/", name = name)],
	)
	result = plan.run_sh(
	description = "Downloading Grafana dashboard: {0}".format(url),
	run = "mkdir -p /dashboards-dl && curl -fsSL -o /dashboards-dl/{0} {1}".format(name, url),
	store = [StoreSpec(src = "/dashboards-dl/", name = name)],
	)

[fjl]

It works with curl, but then the URL would have to be shell-quoted somehow. So that's why I chose run_python, it doesn't have any issues with quoting.

[barnabasbusa]

Closing this — turns out we don't need any code changes here. As of Kurtosis 1.18.3, plan.upload_files accepts arbitrary http(s):// URLs natively, so the existing call on main:

plan.upload_files(dashboard_src, name="additional-grafana-dashboard-{0}".format(index))

…already handles both local paths and URLs without any special-casing or run_python downloader.

Validated end-to-end with:

grafana_params:
  additional_dashboards:
    - "https://raw.githubusercontent.com/rfmoz/grafana-dashboards/master/prometheus/node-exporter-full.json"

→ artifact additional-grafana-dashboard-0 is created and the "Node Exporter Full" dashboard shows up in Grafana.

Thanks @fjl for surfacing the use case — your grafana_params.additional_dashboards: ["https://gist.../dashboard.json"] config works on main today, just bump your Kurtosis to ≥1.18.3.