Skip to content

feat: add disruptoor support#1398

Merged
barnabasbusa merged 12 commits into
mainfrom
codex/add-disruptoor-support
May 18, 2026
Merged

feat: add disruptoor support#1398
barnabasbusa merged 12 commits into
mainfrom
codex/add-disruptoor-support

Conversation

@samcm
Copy link
Copy Markdown
Member

@samcm samcm commented May 17, 2026

Summary

Adds disruptoor as an additional_services option for the ethereum-package.

This wires in a disruptoor launcher that assumes Kurtosis privileged container support from kurtosis-tech/kurtosis#3091. The service is Docker-only and runs with privileged mode, host PID namespace, and a /var/run/docker.sock bind mount so disruptoor can discover and manipulate the enclave containers.

Config

Adds disruptoor_params with image/resources/log settings plus three startup configuration paths:

  • partitions: ethereum-package friendly partition config translated to disruptoor v1 state
  • shaping: ethereum-package friendly shaping config translated to disruptoor v1 state
  • config: raw native disruptoor v1 state escape hatch

config is mutually exclusive with partitions and shaping. Empty config means no startup state is applied and the user can drive disruptoor through its HTTP API.

Example:

additional_services:
  - disruptoor

disruptoor_params:
  partitions:
    - groups:
        - participants: [1, 2]
        - participants: [3, 4]
      components: [el, cl]

Validation

  • git diff --check
  • git diff --cached --check
  • Smoke tested with a Kurtosis build from the privileged-containers PR using kurtosis run --privileged
  • Verified translated partition state through disruptoor /v1/state
  • Verified translated shaping state and disruptoor logs showing applied shaping
  • Verified disruptoor container had Privileged=true, PidMode=host, and /var/run/docker.sock mounted
  • Re-ran .github/tests/examples/disruptoor.yaml locally against this branch with ethpandaops/disruptoor:latest and --image-download always; verified the latest image was pulled, the Disruptoor and Dora services were RUNNING, CL health endpoints returned 200, and Disruptoor logs showed partition rules installed plus shaping applied.

Ready Status

Ready for merge after the required GitHub review/check gates pass.

@samcm samcm changed the title [codex] add disruptoor support feat: add disruptoor support May 17, 2026
@qu0b-reviewer
Copy link
Copy Markdown

qu0b-reviewer Bot commented May 18, 2026

🤖 qu0b-reviewer

Everything is clean. 🫧

Summary: PR #1398 adds first-class support for the Disruptoor network-partitioning/shaping tool, including a full launcher module with a "friendly" config translator, integration into input parsing and main.star, documentation, and tests. It also coincidentally adds zkboost's verifier mode / in-process verification path as a related side feature (return path validation for ZkVM::Verifier). The crate-ci/typos bump to v1.46.2 carries no known advisories.

Issues

  • 🔴 blocker README.md:236,239 — The PR's last commit deleted .github/tests/examples/disruptoor.yaml, but the Disruptoor section in README.md still links to it ([.github/tests/examples/disruptoor.yaml]) and the kurtosis run command references the same path. Clicking the link or running the command will 404. Either restore the example file or remove the broken link from the README.

Reviewed @ 7a02665c

@barnabasbusa barnabasbusa marked this pull request as ready for review May 18, 2026 10:41
Copy link
Copy Markdown
Member Author

samcm commented May 18, 2026

Updated the branch to use the released ethpandaops/disruptoor:latest image and re-ran .github/tests/examples/disruptoor.yaml locally with image downloads forced.

Validation passed: Disruptoor/Dora launched, CL health endpoints returned 200, and Disruptoor logs showed the partition rules installed plus shaping applied. This is ready for merge once the required GitHub review/check gates pass.

Copy link
Copy Markdown
Member Author

samcm commented May 18, 2026

pari is the best boss ever

Signed-off-by: Barnabas Busa <barnabas.busa@ethereum.org>
@barnabasbusa barnabasbusa merged commit 76fea83 into main May 18, 2026
17 checks passed
@barnabasbusa barnabasbusa deleted the codex/add-disruptoor-support branch May 18, 2026 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants