fix(zkboost): fill mock_proving_time defaults from slot duration#1401
Open
barnabasbusa wants to merge 1 commit into
Open
fix(zkboost): fill mock_proving_time defaults from slot duration#1401barnabasbusa wants to merge 1 commit into
barnabasbusa wants to merge 1 commit into
Conversation
Partial overrides like `mock_proving_time: { kind: constant }` silently
became 0ms because dict.get on the missing `ms` key returned 0. Fill in
kind-appropriate defaults (scaled to 2/3 of slot_duration_ms) during
input validation so partial configs behave like the no-override case.
The launcher fallback and the auto-injected default zkvm scale with
slot duration too.
🤖 qu0b-reviewerSummaryThe PR fills in missing Issues
Suggestions
Reviewed @ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mock_proving_time: { kind: constant }silently became 0ms because dict.get on the missingmskey returned 0, while omittingmock_proving_timeentirely fell back to the launcher's hardcoded 6000ms — surprising and inconsistent.slot_duration_ms(2/3 of slot):constant.ms,random.min_ms/max_ms(default_ms/2 .. default_ms*2), andlinear.ms_per_mgas.Test plan
kurtosis lint --format .passeszkvms: [{ kind: mock, proof_type: reth-zisk }]→ mock proving time defaults to 4000ms on 6s slots (2/3 of 6000)zkvms: [{ kind: mock, proof_type: reth-zisk, mock_proving_time: { kind: constant } }]→ resolves to 4000ms (no longer 0ms)zkvms: [{ kind: mock, proof_type: reth-zisk, mock_proving_time: { kind: random } }]→ resolves to 2000–8000ms on 6s slots