fix(core): fix HippyValue ToString crash

etkmao · etkmao · commit 0debaf8c3ba6 · 2025-10-17T15:45:41.000+08:00
diff --git a/modules/footstone/src/hippy_value.cc b/modules/footstone/src/hippy_value.cc
@@ -428,7 +428,9 @@ bool HippyValue::ToBooleanChecked() const {
 
 bool HippyValue::ToString(std::string& str) const {
   bool is_string = IsString();
-  str = str_;
+  if (is_string) {
+    str = str_;
+  }
   return is_string;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -428,7 +428,9 @@ bool HippyValue::ToBooleanChecked() const {`
`428`	`428`
`429`	`429`	`bool HippyValue::ToString(std::string& str) const {`
`430`	`430`	`bool is_string = IsString();`
`431`		`- str = str_;`
	`431`	`+ if (is_string) {`
	`432`	`+ str = str_;`
	`433`	`+ }`
`432`	`434`	`return is_string;`
`433`	`435`	`}`
`434`	`436`