Skip to content

Commit fd60abf

Browse files
committed
add todo
1 parent 705ba6a commit fd60abf

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

lib/cmd.ml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,13 @@ module Cmd = struct
1515
| args -> List.fold_left (fun cmd arg -> Bos.Cmd.add_arg cmd arg) cmd args
1616
;;
1717

18+
(* TODO: nix develop --ignore-env behaves differently than nix-shell --pure
19+
which is causing none of the packages to show up. *)
1820
let nix_develop entrypoint attribute force_experimental_features sh =
1921
Bos.Cmd.v "nix"
2022
|>+ [ "develop" ] @ [ Uri.sprintf_uri_attr_opt entrypoint attribute ]
2123
|>+ Option.value ~default:[] force_experimental_features
24+
(* |>+ [ "--ignore-env"; "-k"; "TERM"; "-k"; "TERMINFO"; "-k"; "HOME"; "-k"; "USER"; "-k"; "DISPLAY" ] *)
2225
|>+ [ "--command"; sh ]
2326
;;
2427

@@ -39,7 +42,6 @@ module Cmd = struct
3942
;;
4043

4144
let legacy_nix_shell_from_installables installables sh =
42-
(* Need to combine/validate that the installables given are all Nixpkgs *)
4345
Bos.Cmd.v "nix-shell" |>+ [ "--packages" ] @ installables |>+ [ "--command"; sh ]
4446
;;
4547

0 commit comments

Comments
 (0)