Skip to content

Commit fe679a6

Browse files
committed
Fixed logical issue
Fix test issue
1 parent 6ac57b8 commit fe679a6

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

app/Http/Controllers/BadgeController.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ public function store(BadgeCreateRequest $request)
9797
// Pay for Badge (force pay as we allow negative balance)
9898
$request->user()->forcePay($badge);
9999

100-
if ($isFreeBadge && $request->user()->free_badge_copies > 0) {
100+
if ($isFreeBadge) {
101101
$total = BadgeCalculationService::calculate(isSpareCopy: true);
102102
for ($i = 0; $i < $request->user()->free_badge_copies; $i++) {
103103
$clone = $badge->replicate();

tests/Feature/BadgeTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@
1717
beforeEach(function () {
1818
$this->user = User::factory()->create();
1919
$this->user->update([
20-
'has_free_badge' => true,
21-
'free_badge_copies' => 1,
20+
'has_free_badge' => false,
21+
'free_badge_copies' => 0,
2222
]);
2323
$event = \App\Models\Event::factory()->create([
2424
'starts_at' => \Carbon\Carbon::parse('2024-06-01'),

0 commit comments

Comments
 (0)