Add more Standard Site logging, ensure associatedProfiles is returned on external view only for SS hydrations (bluesky-social#5001)

* Add some more logs

* Build associatedProfiles inside externalEmbedFromStandardSiteRecords

Hoists the doc/pub profile lookup into the shared SS overlay builder so
both the read-path externalEmbed and the compose-path handler emit
associatedProfiles from the same source of truth, derived from the
selected document/publication refs rather than the post's full
associatedRefs array.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* Changeset

* Format

---------

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>

Author: estrattonbailey

.changeset/chatty-icons-agree.md

@@ -0,0 +1,5 @@
+---
+'@atproto/bsky': patch
+---
+
+Ensure `associatedProfiles` is returned for Standard Site external embed views

packages/bsky/src/hydration/external.ts

@@ -1,6 +1,7 @@
 import { AtUriString } from '@atproto/syntax'
 import { DataPlaneClient } from '../data-plane/client/index.js'
 import { site } from '../lexicons/index.js'
+import { hydrationLogger } from '../logger.js'
 import {
   GetSiteStandardRecordsByRefResponse,
   GetSiteStandardRecordsByURIResponse,
@@ -162,6 +163,14 @@ export const getSiteStandardRecordsFromHydrationMapsByRefs = (
   // (or tampered with), so reject the whole pairing.
   if (document && publication) {
     if (document.info.record.site !== publication.ref.uri) {
+      hydrationLogger.warn(
+        {
+          documentUri: document.ref.uri,
+          documentSite: document.info.record.site,
+          publicationUri: publication.ref.uri,
+        },
+        'site.standard byRefs lookup failed: doc.site does not match hydrated publication.uri',
+      )
       return { document: undefined, publication: undefined }
     }
   }
@@ -172,6 +181,10 @@ export const getSiteStandardRecordsFromHydrationMapsByRefs = (
   if (document && !publication) {
     const site = document.info.record.site
     if (site && site.startsWith('at://')) {
+      hydrationLogger.warn(
+        { documentUri: document.ref.uri, documentSite: site },
+        'site.standard byRefs lookup failed: document.site is AT URI but no matching publication was hydrated',
+      )
       return { document: undefined, publication: undefined }
     }
   }
@@ -234,6 +247,10 @@ export const getSiteStandardRecordsFromHydrationMapsByDocumentUri = (
         }
       }
       if (!publication) {
+        hydrationLogger.warn(
+          { documentUri: document.ref.uri, documentSite: site },
+          'site.standard byDocumentUri lookup failed: document.site is AT URI but no matching publication was hydrated',
+        )
         return { document: undefined, publication: undefined }
       }
     }

packages/bsky/src/util/standard-site.test.ts

@@ -101,6 +101,13 @@ describe(validateStandardSiteForUrl, () => {
         validateStandardSiteForUrl(undefined, pub, 'https://other.com'),
       ).toBe(false)
     })
+
+    it('accepts when assumedUrl has a trailing slash and publication.url does not', () => {
+      const pub = makePub({ url: 'https://atproto.com/blog' })
+      expect(
+        validateStandardSiteForUrl(undefined, pub, 'https://atproto.com/blog/'),
+      ).toBe(true)
+    })
   })
 
   describe('neither', () => {

packages/bsky/src/views/index.ts

@@ -2141,14 +2141,6 @@ export class Views {
       state,
       assumedUrl: embed.external.uri,
     })
-    // Profiles of the owners of pinned `associatedRefs`. Hydrator covers
-    // these DIDs alongside post-author profiles, so misses here only
-    // happen when an actor is unavailable (suspended, deleted, etc.) —
-    // drop those rather than emit `undefined` slots.
-    const associatedProfiles = mapDefined(
-      embed.external.associatedRefs ?? [],
-      (ref) => this.profileBasic(uriToDid(ref.uri), state),
-    ) as ProfileViewBasic[]
     return app.bsky.embed.external.view.$build({
       external: {
         uri: embed.external.uri,
@@ -2163,9 +2155,6 @@ export class Views {
           : undefined,
         ...ssView,
         associatedRefs: embed.external.associatedRefs,
-        associatedProfiles: associatedProfiles.length
-          ? associatedProfiles
-          : undefined,
       },
     })
   }
@@ -2263,7 +2252,7 @@ export class Views {
           documentUri: document?.ref.uri,
           publicationUri: publication?.ref.uri,
         },
-        'SS record(s) failed URL validation for external embed',
+        'site.standard URL validation failed',
       )
       return undefined
     }
@@ -2333,6 +2322,17 @@ export class Views {
       overlay.source = this.externalEmbedSource(publication)
     }
 
+    // Profiles of the owners of the records backing this embed. Hydrator
+    // covers these DIDs alongside post-author profiles, so misses here
+    // only happen when an actor is unavailable (suspended, deleted, etc.)
+    // — drop those rather than emit `undefined` slots.
+    const associatedProfiles = mapDefined(
+      [document?.ref.uri, publication?.ref.uri],
+      (uri) => (uri ? this.profileBasic(uriToDid(uri), state) : undefined),
+    ) as ProfileViewBasic[]
+    if (associatedProfiles.length)
+      overlay.associatedProfiles = associatedProfiles
+
     return overlay
   }