[kustomize_deploy]: Fix InstallPlan approval when deployment_version is empty

rebtoor · amartyasinha · commit daa791825fcb · 2026-01-21T14:28:03.000+05:30
Check both 'is defined' and 'length &gt; 0' for deployment_version so
empty strings correctly fall through to approve any unapproved manual
InstallPlan instead of filtering for 'openstack-operator.' (no version).

Signed-off-by: Roberto Alfieri &lt;ralfieri@redhat.com&gt;
diff --git a/roles/kustomize_deploy/tasks/install_plan.yml b/roles/kustomize_deploy/tasks/install_plan.yml
@@ -28,7 +28,8 @@
   register: _cifmw_kustomize_deploy_install_plans
   until: >
     (
-      cifmw_ci_gen_kustomize_values_deployment_version is defined
+      cifmw_ci_gen_kustomize_values_deployment_version is defined and
+      cifmw_ci_gen_kustomize_values_deployment_version | length > 0
     ) | ternary(
       (
         _cifmw_kustomize_deploy_install_plans.resources |
@@ -52,7 +53,8 @@
     _cifmw_kustomize_deploy_installplan_name: >-
       {{
       (
-        cifmw_ci_gen_kustomize_values_deployment_version is defined
+        cifmw_ci_gen_kustomize_values_deployment_version is defined and
+        cifmw_ci_gen_kustomize_values_deployment_version | length > 0
       ) | ternary(
         (
           _cifmw_kustomize_deploy_install_plans.resources
@@ -76,7 +78,8 @@
     _selected_installplan: >-
       {{
       (
-        cifmw_ci_gen_kustomize_values_deployment_version is defined
+        cifmw_ci_gen_kustomize_values_deployment_version is defined and
+        cifmw_ci_gen_kustomize_values_deployment_version | length > 0
       ) | ternary(
         (
           _cifmw_kustomize_deploy_install_plans.resources

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,8 @@`
`28`	`28`	`register: _cifmw_kustomize_deploy_install_plans`
`29`	`29`	`until: >`
`30`	`30`	`(`
`31`		`- cifmw_ci_gen_kustomize_values_deployment_version is defined`
	`31`	`+ cifmw_ci_gen_kustomize_values_deployment_version is defined and`
	`32`	`+ cifmw_ci_gen_kustomize_values_deployment_version \| length > 0`
`32`	`33`	`) \| ternary(`
`33`	`34`	`(`
`34`	`35`	`_cifmw_kustomize_deploy_install_plans.resources \|`
`@@ -52,7 +53,8 @@`
`52`	`53`	`_cifmw_kustomize_deploy_installplan_name: >-`
`53`	`54`	`{{`
`54`	`55`	`(`
`55`		`- cifmw_ci_gen_kustomize_values_deployment_version is defined`
	`56`	`+ cifmw_ci_gen_kustomize_values_deployment_version is defined and`
	`57`	`+ cifmw_ci_gen_kustomize_values_deployment_version \| length > 0`
`56`	`58`	`) \| ternary(`
`57`	`59`	`(`
`58`	`60`	`_cifmw_kustomize_deploy_install_plans.resources`
`@@ -76,7 +78,8 @@`
`76`	`78`	`_selected_installplan: >-`
`77`	`79`	`{{`
`78`	`80`	`(`
`79`		`- cifmw_ci_gen_kustomize_values_deployment_version is defined`
	`81`	`+ cifmw_ci_gen_kustomize_values_deployment_version is defined and`
	`82`	`+ cifmw_ci_gen_kustomize_values_deployment_version \| length > 0`
`80`	`83`	`) \| ternary(`
`81`	`84`	`(`
`82`	`85`	`_cifmw_kustomize_deploy_install_plans.resources`