fix(auth): add block scope to switch case clauses to prevent variable leaking

Switch statements in JS/TS share scope across case clauses, which can
cause variable declarations to leak or conflict. Wrapped MikroORM and
TypeORM case bodies in their own blocks ({}) so declarations are
lexically scoped to each case.

Author: samuelmbabhazi

packages/core/src/lib/auth/auth.service.ts

@@ -875,7 +875,7 @@ export class AuthService extends SocialAuthService {
 			let user: User;
 
 			switch (this.ormType) {
-				case MultiORMEnum.MikroORM:
+				case MultiORMEnum.MikroORM: {
 					const { where, mikroOptions } = parseTypeORMFindToMikroOrm<User>({
 						where: {
 							id: userId,
@@ -888,8 +888,9 @@ export class AuthService extends SocialAuthService {
 					});
 					user = (await this.mikroOrmUserRepository.findOne(where, mikroOptions)) as User;
 					break;
+				}
 
-				case MultiORMEnum.TypeORM:
+				case MultiORMEnum.TypeORM: {
 					user = await this.typeOrmUserRepository.findOne({
 						where: {
 							id: userId,
@@ -901,6 +902,7 @@ export class AuthService extends SocialAuthService {
 						order: { createdAt: 'DESC' }
 					});
 					break;
+				}
 
 				default:
 					throw new Error(`Method not implemented for ORM type: ${this.ormType}`);
@@ -1634,7 +1636,7 @@ export class AuthService extends SocialAuthService {
 			let user: User;
 
 			switch (this.ormType) {
-				case MultiORMEnum.MikroORM:
+				case MultiORMEnum.MikroORM: {
 					const { where, mikroOptions } = parseTypeORMFindToMikroOrm<User>({
 						where: {
 							id: currentUser.id,
@@ -1646,8 +1648,9 @@ export class AuthService extends SocialAuthService {
 					});
 					user = (await this.mikroOrmUserRepository.findOne(where, mikroOptions)) as User;
 					break;
+				}
 
-				case MultiORMEnum.TypeORM:
+				case MultiORMEnum.TypeORM: {
 					user = await this.typeOrmUserRepository.findOne({
 						where: {
 							id: currentUser.id,
@@ -1658,6 +1661,7 @@ export class AuthService extends SocialAuthService {
 						relations: { role: { rolePermissions: true } }
 					});
 					break;
+				}
 
 				default:
 					throw new Error(`Method not implemented for ORM type: ${this.ormType}`);