fix(plugin): improve input validation and data handling

This commit addresses several issues related to input validation and data handling within the plugin registry.
In `create-plugin-command.handler.ts`, the validation logic has been refined to more accurately check for required version information, particularly when `version.sources` is present but empty. The destructuring of `input` has also been moved after the validation to prevent potential errors.
In `update-plugin-command.handler.ts`, a check for `input` being null or undefined has been added before attempting to access its properties, preventing potential runtime errors. Additionally, the update logic now correctly uses `input.propertyName` instead of `input?.propertyName` for mandatory fields.
In `plugin-billing.controller.ts`, the condition for applying search filters has been made more explicit by introducing a `hasFilters` variable, improving readability. This change ensures that filters are only applied when there are actual search options defined.

Author: adkif

packages/plugins/registry/src/lib/application/plugin/commands/handlers/create-plugin-command.handler.ts

@@ -26,17 +26,13 @@ export class CreatePluginCommandHandler implements ICommandHandler<CreatePluginC
 	 */
 	public async execute(command: CreatePluginCommand): Promise<IPlugin> {
 		const { input } = command;
-		const { subscriptionPlans = [], ...pluginInput } = input;
 
-		// Validate input
-		if (
-			!pluginInput ||
-			!pluginInput.version ||
-			(pluginInput.version.sources && pluginInput.version.sources.length === 0 && !pluginInput.version)
-		) {
+		if (!input || !input.version || (Array.isArray(input.version.sources) && input.version.sources.length === 0)) {
 			throw new BadRequestException('Invalid plugin data: Source requires version information');
 		}
 
+		const { subscriptionPlans = [], ...pluginInput } = input;
+
 		const queryRunner = this.dataSource.createQueryRunner();
 		await queryRunner.connect();
 		await queryRunner.startTransaction();

packages/plugins/registry/src/lib/application/plugin/commands/handlers/update-plugin-command.handler.ts

@@ -32,6 +32,10 @@ export class UpdatePluginCommandHandler implements ICommandHandler<UpdatePluginC
 			throw new BadRequestException('Plugin ID is required');
 		}
 
+		if (!input) {
+			throw new BadRequestException('Plugin update input is required');
+		}
+
 		// Start a transaction for updating the plugin and related entities
 		const queryRunner = this.dataSource.createQueryRunner();
 		await queryRunner.connect();
@@ -68,17 +72,17 @@ export class UpdatePluginCommandHandler implements ICommandHandler<UpdatePluginC
 				}
 			} // Update plugin with only provided fields
 			const pluginUpdate: Partial<IPlugin> = {
-				name: input?.name,
-				type: input?.type,
-				status: input?.status,
-				description: input?.description,
-				isActive: input?.isActive,
-				repository: input?.repository,
-				author: input?.author,
-				license: input?.license,
-				homepage: input?.homepage,
-				requiresSubscription: input?.requiresSubscription,
-				...(input?.categoryId && { categoryId: input.categoryId })
+				name: input.name,
+				type: input.type,
+				status: input.status,
+				description: input.description,
+				isActive: input.isActive,
+				repository: input.repository,
+				author: input.author,
+				license: input.license,
+				homepage: input.homepage,
+				requiresSubscription: input.requiresSubscription,
+				...(input.categoryId && { categoryId: input.categoryId })
 			};
 			await this.pluginService.update(id, pluginUpdate);
 

packages/plugins/registry/src/lib/infrastructure/controllers/plugin-billing.controller.ts

@@ -97,7 +97,8 @@ export class PluginBillingController {
 			searchOptions.status = statusMap[status];
 		}
 
-		if (searchOptions && Object.keys(searchOptions).length > 0) {
+		const hasFilters = Object.keys(searchOptions).length > 0;
+		if (hasFilters) {
 			const result = await this.pluginBillingService.findBillings(searchOptions);
 			return {
 				items: result,