Review AI suggestions for PRs #443 and #444 (#446)

* fix: security improvements, bug fixes, and i18n consistency

Security improvements:
- Add URL validation to prevent open redirect vulnerabilities in checkout routes
- Use generic error messages for 500 responses to avoid exposing sensitive details
- Add JSON parsing validation with proper 400 responses for malformed requests
- Validate item existence before recording views to prevent data pollution
- Add customer ID validation for Polar checkout (consistent with Stripe)

Bug fixes:
- Fix pagination issues (restore standard pagination UI, fix page reset on search)
- Fix webhook handlers to properly detect sponsor ad renewals (check subscription metadata)
- Fix admin stats to show global counts instead of page-scoped counts
- Fix modal closing logic to check operation success before closing
- Fix collection card spinner to only show on regular left-click navigation
- Fix item view recording to validate item existence for all users
- Fix limit parameter validation to handle NaN and invalid values properly
- Fix isActive consistency in admin collections page

i18n improvements:
- Replace hardcoded strings with translation keys in collection components
- Add missing translations for aria-labels and status messages

Code quality:
- Remove unused props and imports
- Improve error handling consistency across API routes
- Add proper existence checks before database operations
- Fix cache revalidation to use correct identifiers (slug vs id)

Affected areas:
- API routes (sponsor ads, collections, items, payments, webhooks)
- Admin pages (collections, sponsorships)
- UI components (collections, categories, billing)
- Webhook handlers (Stripe, Polar)

* fix: improve error handling and internationalization

- Add missing 404 handling in cancel sponsor ad route
- Complete internationalization of assign items modal
- Refactor categories-grid to use exported totalPages function

* fix: resolve API errors and missing translation

- Increase max limit for collections endpoint (100 -> 1000)
- Add missing 'EDIT' translation key in common section
- Improve pagination parameter validation for collections

Author: Innocent-Akim

app/[locale]/admin/collections/page.tsx

@@ -54,7 +54,7 @@ export default function AdminSponsorshipsPage() {
 		deleteSponsorAd,
 		setStatusFilter,
 		setSearchTerm: setHookSearchTerm,
-		setCurrentPage,
+		setCurrentPage
 	} = useAdminSponsorAds();
 
 	// Calculate active filters
@@ -63,20 +63,21 @@ export default function AdminSponsorshipsPage() {
 	// Sync debounced search term to hook (only when debounced value changes)
 	useEffect(() => {
 		setHookSearchTerm(debouncedSearchTerm);
-		if (debouncedSearchTerm !== '') {
-			setCurrentPage(1); // Reset to page 1 when search changes
-		}
+		setCurrentPage(1); // Reset to page 1 when search changes (including when cleared)
 	}, [debouncedSearchTerm, setHookSearchTerm, setCurrentPage]);
 
 	// Handlers
 	const handleSearchChange = useCallback((value: string) => {
 		setSearchTerm(value);
 	}, []);
 
-	const handleStatusChange = useCallback((value: SponsorAdStatus | undefined) => {
-		setLocalStatusFilter(value);
-		setStatusFilter(value);
-	}, [setStatusFilter]);
+	const handleStatusChange = useCallback(
+		(value: SponsorAdStatus | undefined) => {
+			setLocalStatusFilter(value);
+			setStatusFilter(value);
+		},
+		[setStatusFilter]
+	);
 
 	const handleClearFilters = useCallback(() => {
 		setSearchTerm('');
@@ -86,20 +87,25 @@ export default function AdminSponsorshipsPage() {
 		setCurrentPage(1);
 	}, [setHookSearchTerm, setStatusFilter, setCurrentPage]);
 
-	const handleApprove = useCallback(async (id: string) => {
-		const result = await approveSponsorAd(id);
-		if (result.requiresForceApprove) {
-			// Show confirmation modal for force approve
-			setPendingApproveId(id);
-			setForceApproveModalOpen(true);
-		}
-	}, [approveSponsorAd]);
+	const handleApprove = useCallback(
+		async (id: string) => {
+			const result = await approveSponsorAd(id);
+			if (result.requiresForceApprove) {
+				// Show confirmation modal for force approve
+				setPendingApproveId(id);
+				setForceApproveModalOpen(true);
+			}
+		},
+		[approveSponsorAd]
+	);
 
 	const handleForceApprove = useCallback(async () => {
 		if (!pendingApproveId) return;
-		await approveSponsorAd(pendingApproveId, true);
-		setForceApproveModalOpen(false);
-		setPendingApproveId(null);
+		const result = await approveSponsorAd(pendingApproveId, true);
+		if (result.success) {
+			setForceApproveModalOpen(false);
+			setPendingApproveId(null);
+		}
 	}, [pendingApproveId, approveSponsorAd]);
 
 	const handleCloseForceApproveModal = useCallback(() => {
@@ -127,23 +133,32 @@ export default function AdminSponsorshipsPage() {
 		}
 	}, [selectedSponsorAd, rejectionReason, rejectSponsorAd, handleCloseRejectModal]);
 
-	const handleCancel = useCallback(async (id: string) => {
-		if (!confirm(t('CONFIRM_CANCEL'))) return;
-		await cancelSponsorAd(id);
-	}, [t, cancelSponsorAd]);
+	const handleCancel = useCallback(
+		async (id: string) => {
+			if (!confirm(t('CONFIRM_CANCEL'))) return;
+			await cancelSponsorAd(id);
+		},
+		[t, cancelSponsorAd]
+	);
 
-	const handleDelete = useCallback(async (id: string) => {
-		if (confirmDeleteId !== id) {
-			setConfirmDeleteId(id);
-			return;
-		}
-		await deleteSponsorAd(id);
-		setConfirmDeleteId(null);
-	}, [confirmDeleteId, deleteSponsorAd]);
+	const handleDelete = useCallback(
+		async (id: string) => {
+			if (confirmDeleteId !== id) {
+				setConfirmDeleteId(id);
+				return;
+			}
+			await deleteSponsorAd(id);
+			setConfirmDeleteId(null);
+		},
+		[confirmDeleteId, deleteSponsorAd]
+	);
 
-	const handlePageChange = useCallback((page: number) => {
-		setCurrentPage(page);
-	}, [setCurrentPage]);
+	const handlePageChange = useCallback(
+		(page: number) => {
+			setCurrentPage(page);
+		},
+		[setCurrentPage]
+	);
 
 	// Loading state
 	if (isLoading && sponsorAds.length === 0) {
@@ -185,11 +200,7 @@ export default function AdminSponsorshipsPage() {
 			{/* Pagination */}
 			{totalPages > 1 && (
 				<div className="flex flex-col items-center mt-8 space-y-4">
-					<UniversalPagination
-						page={currentPage}
-						totalPages={totalPages}
-						onPageChange={handlePageChange}
-					/>
+					<UniversalPagination page={currentPage} totalPages={totalPages} onPageChange={handlePageChange} />
 				</div>
 			)}
 
@@ -205,33 +216,20 @@ export default function AdminSponsorshipsPage() {
 			/>
 
 			{/* Force Approve Modal */}
-			<Modal
-				isOpen={forceApproveModalOpen}
-				onClose={handleCloseForceApproveModal}
-				size="md"
-			>
+			<Modal isOpen={forceApproveModalOpen} onClose={handleCloseForceApproveModal} size="md">
 				<ModalContent>
 					<ModalHeader className="flex items-center gap-2">
 						<AlertTriangle className="w-5 h-5 text-amber-500" />
 						{t('FORCE_APPROVE_TITLE')}
 					</ModalHeader>
 					<ModalBody>
-						<p className="text-gray-600 dark:text-gray-400">
-							{t('FORCE_APPROVE_MESSAGE')}
-						</p>
+						<p className="text-gray-600 dark:text-gray-400">{t('FORCE_APPROVE_MESSAGE')}</p>
 					</ModalBody>
 					<ModalFooter>
-						<Button
-							variant="light"
-							onPress={handleCloseForceApproveModal}
-						>
+						<Button variant="light" onPress={handleCloseForceApproveModal}>
 							{t('CANCEL')}
 						</Button>
-						<Button
-							color="warning"
-							onPress={handleForceApprove}
-							isLoading={isSubmitting}
-						>
+						<Button color="warning" onPress={handleForceApprove} isLoading={isSubmitting}>
 							{t('FORCE_APPROVE')}
 						</Button>
 					</ModalFooter>

app/[locale]/admin/sponsorships/page.tsx

@@ -4,21 +4,15 @@ import { useTranslations } from 'next-intl';
 import Hero from '@/components/hero';
 import Link from 'next/link';
 import CategoriesGrid from '@/components/categories-grid';
-import { Category, ItemData, Tag } from '@/lib/content';
+import { Category } from '@/lib/content';
 import { useLayoutTheme, LayoutHome } from '@/components/context';
-import { Paginate } from '@/components/filters/components/pagination/paginate';
-import { totalPages } from '@/lib/paginate';
 import { ListingSkeleton } from '@/components/ui/skeleton';
 import { Container } from '@/components/ui/container';
 
 interface ListingCategoriesProps {
-	total: number;
-	start: number;
 	page: number;
 	basePath: string;
 	categories: Category[];
-	tags: Tag[];
-	items: ItemData[];
 }
 
 function ListingCategoriesContent(props: ListingCategoriesProps) {
@@ -41,15 +35,6 @@ function ListingCategoriesContent(props: ListingCategoriesProps) {
 			>
 				{layoutHome === LayoutHome.HOME_ONE && <HomeOneLayout categories={props.categories} />}
 				{layoutHome === LayoutHome.HOME_TWO && <HomeTwoLayout categories={props.categories} />}
-				{paginationType === 'standard' && totalPages(props.categories.length) > 1 && (
-					<footer className="flex items-center justify-center">
-						<Paginate
-							basePath={props.basePath}
-							initialPage={props.page}
-							total={totalPages(props.categories.length)}
-						/>
-					</footer>
-				)}
 			</Hero>
 		</>
 	);
@@ -123,11 +108,7 @@ function HomeOneLayout({ categories }: { categories: Category[] }) {
 	);
 }
 
-function HomeTwoLayout({
-	categories
-}: {
-	categories: Category[];
-}) {
+function HomeTwoLayout({ categories }: { categories: Category[] }) {
 	const t = useTranslations();
 
 	return (

app/[locale]/categories/listing-categories.tsx

@@ -1,47 +1,31 @@
-import { getCachedItems } from "@/lib/content";
-import ListingCategories from "./listing-categories";
-import { notFound } from "next/navigation";
-import { getCategoriesEnabled } from "@/lib/utils/settings";
+import { getCachedItems } from '@/lib/content';
+import ListingCategories from './listing-categories';
+import { notFound } from 'next/navigation';
+import { getCategoriesEnabled } from '@/lib/utils/settings';
 
 export const revalidate = 10;
 
 // Allow non-English locales to be generated on-demand (ISR)
 export const dynamicParams = true;
 
 export async function generateStaticParams() {
-  // Only pre-build English locale for optimal build size
-  return [{ locale: 'en' }];
+	// Only pre-build English locale for optimal build size
+	return [{ locale: 'en' }];
 }
 
-export default async function CategoriesPage({
-  params,
-}: {
-  params: Promise<{ locale: string }>;
-}) {
-  // Check if categories are enabled
-  const categoriesEnabled = getCategoriesEnabled();
-  if (!categoriesEnabled) {
-    notFound();
-  }
+export default async function CategoriesPage({ params }: { params: Promise<{ locale: string }> }) {
+	// Check if categories are enabled
+	const categoriesEnabled = getCategoriesEnabled();
+	if (!categoriesEnabled) {
+		notFound();
+	}
 
-  const { locale } = await params;
-  const { categories, tags, items } = await getCachedItems({ lang: locale });
+	const { locale } = await params;
+	const { categories } = await getCachedItems({ lang: locale });
 
-  // Calculate pagination info
-  const total = items.length;
-  const page = 1;
-  const start = 0;
-  const basePath = "/categories";
+	// Calculate pagination info
+	const page = 1;
+	const basePath = '/categories';
 
-  return (
-    <ListingCategories
-      categories={categories}
-      tags={tags}
-      items={items}
-      total={total}
-      start={start}
-      page={page}
-      basePath={basePath}
-    />
-  );
+	return <ListingCategories categories={categories} page={page} basePath={basePath} />;
 }