Skip to content

Make the hint text visible again #15562

Open
@octopusinvitro

Description

Problem

After adding HTML validation to viewer-sinatra, some attributes had to be removed in order for the validation to pass. The “Search by country name” hint text now is missing from the search input on the homepage as a result of this.

Before:

screen shot 2016-09-20 at 17 24 35

After:

screen shot 2016-09-20 at 17 24 45

(Images by @zarino )

Proposed Solution

Since the text input (generated by selectToAutocomplete) uses copy-attributes-to-text-field to soak up whatever HTML attributes the source <select> element had. I guess, a satisfactory solution if we still want W3C compliant markup, would be to add the placeholder attribute back in with JavaScript, immediately before we call . selectToAutocomplete() in main.js.
-- Zarino.

Acceptance Criteria

The hint text is visible again in the search input on the homepage.

Metadata

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions