wip

Author: julienrbrt

modules/rollkitmngr/keeper/grpc_query.go

@@ -2,9 +2,7 @@ package keeper
 
 import (
 	"context"
-	"errors"
 
-	"cosmossdk.io/collections"
 	sdkerrors "github.com/cosmos/cosmos-sdk/types/errors"
 
 	"github.com/rollkit/go-execution-abci/modules/rollkitmngr/types"
@@ -21,9 +19,31 @@ func NewQueryServer(keeper Keeper) types.QueryServer {
 	return queryServer{Keeper: keeper}
 }
 
-// Sequencers returns the current sequencers.
-// Note it is only a wrapper around the staking module's query.
-func (q queryServer) Sequencers(ctx context.Context, _ *types.QuerySequencersRequest) (*types.QuerySequencersResponse, error) {
+// Attesters returns the current attesters.
+// Note it is only a wrapper around the staking module's query (iff the attesters are enabled).
+func (q queryServer) Attesters(context.Context, *types.QueryAttestersRequest) (*types.QueryAttestersResponse, error) {
+	// err := q.NextSequencers.Walk(ctx, nil, func(key uint64, sequencer types.Sequencer) (bool, error) {
+	// 	sequencers = append(sequencers, types.SequencerChanges{
+	// 		BlockHeight: key,
+	// 		Sequencers:  []types.Sequencer{sequencer},
+	// 	})
+	// 	return false, nil
+	// })
+	// if err != nil && !errors.Is(err, collections.ErrNotFound) {
+	// 	return nil, err
+	// }
+
+	panic("unimplemented")
+}
+
+// IsMigrating implements types.QueryServer.
+func (q queryServer) IsMigrating(context.Context, *types.QueryIsMigratingRequest) (*types.QueryIsMigratingResponse, error) {
+	panic("unimplemented")
+}
+
+// Attesters returns the current attesters.
+// Note it is only a wrapper around the staking module's query (iff the attesters are disabled). Otherwise it fetches from the module state.
+func (q queryServer) Sequencer(ctx context.Context, _ *types.QuerySequencerRequest) (*types.QuerySequencerResponse, error) {
 	vals, err := q.stakingKeeper.GetLastValidators(ctx)
 	if err != nil {
 		return nil, sdkerrors.ErrLogic.Wrapf("failed to get last validators")
@@ -33,37 +53,14 @@ func (q queryServer) Sequencers(ctx context.Context, _ *types.QuerySequencersReq
 	// In the meantime, this is enough to determine if the chain is using rollkit or not.
 	// There is one false positive for single validators chains, but those are more often local testnets.
 	if len(vals) > 1 {
-		return &types.QuerySequencersResponse{}, sdkerrors.ErrLogic.Wrapf("chain is currently not using Rollkit")
-	}
-
-	sequencers := make([]types.Sequencer, len(vals))
-	for i, val := range vals {
-		sequencers[i] = types.Sequencer{
-			Name:            val.GetMoniker(),
-			ConsensusPubkey: val.ConsensusPubkey,
-		}
-	}
-
-	return &types.QuerySequencersResponse{
-		Sequencers: sequencers,
-	}, nil
-}
-
-// SequencersChanges returns the planned sequencers changes.
-func (q queryServer) SequencersChanges(ctx context.Context, _ *types.QuerySequencersChangesRequest) (*types.QuerySequencersChangesResponse, error) {
-	var sequencers []types.SequencerChanges
-	err := q.NextSequencers.Walk(ctx, nil, func(key uint64, sequencer types.Sequencer) (bool, error) {
-		sequencers = append(sequencers, types.SequencerChanges{
-			BlockHeight: key,
-			Sequencers:  []types.Sequencer{sequencer},
-		})
-		return false, nil
-	})
-	if err != nil && !errors.Is(err, collections.ErrNotFound) {
-		return nil, err
+		// TODO
+		// chain is using attesters, fallback to something else
 	}
 
-	return &types.QuerySequencersChangesResponse{
-		SequencerChanges: sequencers,
+	return &types.QuerySequencerResponse{
+		Sequencer: types.Sequencer{
+			Name:            vals[0].GetMoniker(),
+			ConsensusPubkey: vals[0].ConsensusPubkey,
+		},
 	}, nil
 }

modules/rollkitmngr/keeper/msg_server.go

@@ -21,27 +21,21 @@ func NewMsgServerImpl(keeper Keeper) types.MsgServer {
 	return &msgServer{Keeper: keeper}
 }
 
-func (k msgServer) ChangeSequencers(ctx context.Context, msg *types.MsgChangeSequencers) (*types.MsgChangeSequencersResponse, error) {
+func (k msgServer) MigrateToRollkit(ctx context.Context, msg *types.MsgRollkitMigrate) (*types.MsgMigrateToRollkitResponse, error) {
 	if k.authority != msg.Authority {
 		return nil, govtypes.ErrInvalidSigner.Wrapf("invalid authority; expected %s, got %s", k.authority, msg.Authority)
 	}
 
-	if len(msg.Sequencers) == 0 {
-		return nil, sdkerrors.ErrNotSupported.Wrapf("a sequencer is required.")
-	}
-
-	if len(msg.Sequencers) > 1 {
-		return nil, sdkerrors.ErrNotSupported.Wrapf("currently only one sequencer can be set at a time")
-	}
-
 	sdkCtx := sdk.UnwrapSDKContext(ctx)
 	if msg.BlockHeight < uint64(sdkCtx.BlockHeight()) {
 		return nil, sdkerrors.ErrInvalidRequest.Wrapf("block height %d must be greater than current block height %d", msg.BlockHeight, sdkCtx.BlockHeight())
 	}
 
-	if err := k.NextSequencers.Set(ctx, msg.BlockHeight, msg.Sequencers[0]); err != nil {
+	// TODO: set attesters
+
+	if err := k.NextSequencers.Set(ctx, msg.BlockHeight, msg.Sequencer); err != nil {
 		return nil, err
 	}
 
-	return &types.MsgChangeSequencersResponse{}, nil
+	return &types.MsgMigrateToRollkitResponse{}, nil
 }

modules/rollkitmngr/types/codec.go

@@ -9,13 +9,13 @@ import (
 )
 
 func RegisterLegacyAminoCodec(cdc *codec.LegacyAmino) {
-	legacy.RegisterAminoMsg(cdc, &MsgChangeSequencers{}, "rollkitmngr/v1/MsgChangeSequencers")
+	legacy.RegisterAminoMsg(cdc, &MsgRollkitMigrate{}, "rollkitmngr/v1/MsgRollkitMigrate")
 }
 
 // RegisterInterfaces registers the x/sequencer interfaces types with the interface registry
 func RegisterInterfaces(registry types.InterfaceRegistry) {
 	registry.RegisterImplementations((*sdk.Msg)(nil),
-		&MsgChangeSequencers{},
+		&MsgRollkitMigrate{},
 	)
 
 	msgservice.RegisterMsgServiceDesc(registry, &_Msg_serviceDesc)