Enable subsecond block times using unix nano for Time in BaseHeader (#1146)

<!--
Please read and fill out this form before submitting your PR.

Please make sure you have reviewed our contributors guide before
submitting your
first PR.
-->

## Overview

Closes: #1147

<!-- 
Please provide an explanation of the PR, including the appropriate
context,
background, goal, and rationale. If there is an issue with this
information,
please provide a tl;dr and link the issue. 
-->

## Checklist

<!-- 
Please complete the checklist to ensure that the PR is ready to be
reviewed.

IMPORTANT:
PRs should be left in Draft until the below checklist is completed.
-->

- [x] New and updated code has appropriate documentation
- [x] New and updated code has new and/or updated testing
- [x] Required CI checks are passing
- [ ] Visual proof for any user facing features like CLI or
documentation updates
- [x] Linked issues closed with keywords

Author: Manav-Aggarwal

block/manager.go

@@ -38,9 +38,12 @@ const defaultBlockTime = 1 * time.Second
 // This is temporary solution. It will be removed in future versions.
 const maxSubmitAttempts = 30
 
-// Applies to all channels, 100 is a large enough buffer to avoid blocking
+// Applies to most channels, 100 is a large enough buffer to avoid blocking
 const channelLength = 100
 
+// Applies to the blockInCh, 10000 is a large enough number for blocks per DA block.
+const blockInChLength = 10000
+
 // initialBackoff defines initial value for block submission backoff
 var initialBackoff = 100 * time.Millisecond
 
@@ -177,7 +180,7 @@ func NewManager(
 		// channels are buffered to avoid blocking on input/output operations, buffer sizes are arbitrary
 		HeaderCh:          make(chan *types.SignedHeader, channelLength),
 		BlockCh:           make(chan *types.Block, channelLength),
-		blockInCh:         make(chan newBlockEvent, channelLength),
+		blockInCh:         make(chan newBlockEvent, blockInChLength),
 		blockStoreMtx:     new(sync.Mutex),
 		blockStore:        blockStore,
 		retrieveMtx:       new(sync.Mutex),
@@ -436,9 +439,8 @@ func (m *Manager) BlockStoreRetrieveLoop(ctx context.Context) {
 			}
 			daHeight := atomic.LoadUint64(&m.daHeight)
 			for _, block := range blocks {
-				m.blockInCh <- newBlockEvent{block, daHeight}
 				m.logger.Debug("block retrieved from p2p block sync", "blockHeight", block.Height(), "daHeight", daHeight)
-
+				m.blockInCh <- newBlockEvent{block, daHeight}
 			}
 		}
 		lastBlockStoreHeight = blockStoreHeight
@@ -518,7 +520,10 @@ func (m *Manager) processNextDABlock(ctx context.Context) error {
 			for _, block := range blockResp.Blocks {
 				blockHash := block.Hash().String()
 				m.blockCache.setHardConfirmed(blockHash)
-				m.blockInCh <- newBlockEvent{block, daHeight}
+				m.logger.Info("block marked as hard confirmed", "blockHeight", block.Height(), "blockHash", blockHash)
+				if !m.blockCache.isSeen(blockHash) {
+					m.blockInCh <- newBlockEvent{block, daHeight}
+				}
 			}
 			return nil
 		}

config/defaults.go

@@ -21,7 +21,8 @@ var DefaultNodeConfig = NodeConfig{
 	Aggregator:     false,
 	LazyAggregator: false,
 	BlockManagerConfig: BlockManagerConfig{
-		BlockTime:   30 * time.Second,
+		BlockTime:   1 * time.Second,
+		DABlockTime: 30 * time.Second,
 		NamespaceID: types.NamespaceID{},
 	},
 	DALayer:  "mock",

da/mock/util.go

@@ -152,7 +152,7 @@ func RandShares(total int) ([]share.Share, error) {
 		return nil, fmt.Errorf("total must be power of 2: %d", total)
 	}
 
-	var r = rand.New(rand.NewSource(time.Now().Unix())) //nolint:gosec
+	var r = rand.New(rand.NewSource(time.Now().UnixNano())) //nolint:gosec
 	shares := make([]share.Share, total)
 	for i := range shares {
 		shr := make([]byte, appconsts.ShareSize)
@@ -174,7 +174,7 @@ func RandShares(total int) ([]share.Share, error) {
 
 // RandNamespace generates random valid data namespace for testing purposes.
 func RandNamespace() share.Namespace {
-	var r = rand.New(rand.NewSource(time.Now().Unix())) //nolint:gosec
+	var r = rand.New(rand.NewSource(time.Now().UnixNano())) //nolint:gosec
 	rb := make([]byte, namespace.NamespaceVersionZeroIDSize)
 	r.Read(rb) // nolint:gosec
 	for {

state/executor.go

@@ -104,7 +104,7 @@ func (e *BlockExecutor) CreateBlock(height uint64, lastCommit *types.Commit, las
 				BaseHeader: types.BaseHeader{
 					ChainID: e.chainID,
 					Height:  height,
-					Time:    uint64(time.Now().Unix()), // TODO(tzdybal): how to get TAI64?
+					Time:    uint64(time.Now().UnixNano()), // TODO(tzdybal): how to get TAI64?
 				},
 				//LastHeaderHash: lastHeaderHash,
 				//LastCommitHash:  lastCommitHash,

state/indexer/query_range.go

@@ -48,7 +48,7 @@ func (qr QueryRange) LowerBoundValue() interface{} {
 		tmp := new(big.Int)
 		return tmp.Add(t, big.NewInt(1))
 	case time.Time:
-		return t.Unix() + 1
+		return t.UnixNano() + 1
 
 	default:
 		panic("not implemented")
@@ -73,7 +73,7 @@ func (qr QueryRange) UpperBoundValue() interface{} {
 		tmp := new(big.Int)
 		return tmp.Sub(t, big.NewInt(1))
 	case time.Time:
-		return t.Unix() - 1
+		return t.UnixNano() - 1
 
 	default:
 		panic("not implemented")

types/header.go

@@ -15,7 +15,7 @@ type Hash = header.Hash
 type BaseHeader struct {
 	// Height represents the block height (aka block number) of a given header
 	Height uint64
-	// Time contains Unix time of a block
+	// Time contains Unix nanotime of a block
 	Time uint64
 	// The Chain ID
 	ChainID string
@@ -71,8 +71,9 @@ func (h *Header) LastHeader() Hash {
 	return h.LastHeaderHash[:]
 }
 
+// Returns unix time with nanosecond precision
 func (h *Header) Time() time.Time {
-	return time.Unix(int64(h.BaseHeader.Time), 0)
+	return time.Unix(0, int64(h.BaseHeader.Time))
 }
 
 func (h *Header) Verify(untrst header.Header) error {

types/signed_header_test.go

@@ -56,14 +56,14 @@ func TestVerify(t *testing.T) {
 		},
 		{
 			prepare: func() *SignedHeader {
-				untrustedAdj.Header.BaseHeader.Time = uint64(untrustedAdj.Header.Time().Truncate(time.Hour).Unix())
+				untrustedAdj.Header.BaseHeader.Time = uint64(untrustedAdj.Header.Time().Truncate(time.Hour).UnixNano())
 				return untrustedAdj
 			},
 			err: true,
 		},
 		{
 			prepare: func() *SignedHeader {
-				untrustedAdj.Header.BaseHeader.Time = uint64(untrustedAdj.Header.Time().Add(time.Minute).Unix())
+				untrustedAdj.Header.BaseHeader.Time = uint64(untrustedAdj.Header.Time().Add(time.Minute).UnixNano())
 				return untrustedAdj
 			},
 			err: true,

types/test_utils.go

@@ -37,7 +37,7 @@ func GetRandomSignedHeader() (*SignedHeader, ed25519.PrivKey, error) {
 			BaseHeader: BaseHeader{
 				ChainID: "test",
 				Height:  rand.Uint64(), //nolint:gosec,
-				Time:    uint64(time.Now().Unix()),
+				Time:    uint64(time.Now().UnixNano()),
 			},
 			LastHeaderHash:  GetRandomBytes(32),
 			LastCommitHash:  GetRandomBytes(32),
@@ -70,7 +70,7 @@ func GetNextRandomHeader(signedHeader *SignedHeader, privKey ed25519.PrivKey) (*
 			BaseHeader: BaseHeader{
 				ChainID: "test",
 				Height:  uint64(signedHeader.Height() + 1),
-				Time:    uint64(time.Now().Unix()),
+				Time:    uint64(time.Now().UnixNano()),
 			},
 			LastHeaderHash:  signedHeader.Hash(),
 			DataHash:        GetRandomBytes(32),