Skip to content

Commit d766b04

Browse files
committed
replace jupyter notebook with python script generated from it
1 parent 232ccd6 commit d766b04

File tree

5 files changed

+5025
-6481
lines changed

5 files changed

+5025
-6481
lines changed

Makefile

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,6 @@ benchmark_wasm_engines:
3232

3333
benchmark: benchmark_scout_engines benchmark_wasm_engines benchmark_evm_engines benchmark_evm_precompiles
3434

35-
# Default timeout is 30 seconds, but our cells are quite big, increase it to 120 seconds.
36-
# More info: https://github.com/jupyter/nbconvert/issues/256#issuecomment-188405852
37-
# TODO: upgrade to newer nbconvert which sets the timeout to off by default
38-
notebook:
39-
cd notebooks && \
40-
jupyter nbconvert --execute --ExecutePreprocessor.timeout=120 --to notebook --inplace wasm-engines.ipynb && \
41-
python3 -m nbconvert --ClearOutputPreprocessor.enabled=True --inplace wasm-engines.ipynb # delete some cruft from the notebook to make it more VCS-friendly
35+
generate_charts:
36+
cd charts && \
37+
python3 generate-charts.py

README.md

Lines changed: 2 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -86,27 +86,13 @@ Run benchmarks
8686
make benchmark_scout_engines
8787
```
8888

89-
## Generate charts using jupyter notebooks
89+
## Generate charts
9090

9191
Install python deps for plotting benchmark graphs:
9292

9393
```shell
9494
$ pip install -r requirements.txt
95-
```
96-
97-
Launch a server to access generated charts in Jupyter notebooks:
98-
99-
```shell
100-
$ cd notebooks
101-
$ jupyter-notebook
102-
```
103-
104-
Follow the instructions on the console to access the notebook from the browser.
105-
106-
Alternatively extract the images to the `images` directory by running:
107-
108-
```shell
109-
$ make notebook
95+
$ make generate_charts
11096
```
11197

11298
## EVM engine versions

0 commit comments

Comments
 (0)