Skip to content

Commit 5274292

Browse files
authored
Merge pull request #518 from ewasm/engine-symbols
CMake: Hide symbols from wasm engines included
2 parents db3bb2b + ab29b42 commit 5274292

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

cmake/ProjectWAVM.cmake

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ set(llvmjit_library ${binary_dir}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}LLVMJIT${CMA
2424

2525
set(other_libraries ${platform_library} ${wasm_library} ${ir_library} ${logging_library} ${unwind_library} ${llvmjit_library})
2626

27+
set(flags "-Wno-error -fvisibility=hidden")
2728

2829
ExternalProject_Add(wavm
2930
PREFIX ${prefix}
@@ -41,7 +42,8 @@ ExternalProject_Add(wavm
4142
-DCMAKE_BUILD_TYPE=Release
4243
-DLLVM_DIR=${LLVM_DIR}
4344
-DCMAKE_POSITION_INDEPENDENT_CODE=ON
44-
-DCMAKE_CXX_FLAGS=-Wno-error
45+
-DCMAKE_CXX_FLAGS=${flags}
46+
-DCMAKE_C_FLAGS=${flags}
4547
INSTALL_COMMAND ""
4648
BUILD_BYPRODUCTS ${runtime_library} ${other_libraries}
4749
)

cmake/ProjectWabt.cmake

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,8 @@ ExternalProject_Add(wabt
2626
-DBUILD_TESTS=OFF
2727
-DBUILD_TOOLS=OFF
2828
-DCMAKE_POSITION_INDEPENDENT_CODE=ON
29+
-DCMAKE_CXX_FLAGS=-fvisibility=hidden
30+
-DCMAKE_C_FLAGS=-fvisibility=hidden
2931
INSTALL_COMMAND ""
3032
BUILD_BYPRODUCTS ${wabt_library}
3133
)

0 commit comments

Comments
 (0)