Is storing the Italic Angle in Defaults necessary?

[Mark2Mark]

Italify/Italify.glyphsFilter/Contents/Resources/plugin.py

Line 49 in 931054c

Glyphs.defaults["com.eweracs.italify.angle"] = Glyphs.font.selectedLayers[0].master.italicAngle

Just a question perhaps: Is this line a) safe and b) necessary?
a) It is possible to open a font with no layer selected. In that case it will store some sort of nil value into the defaults.
b) I looked at the code for all occurrences of this default value, and it never appears to me that it is required to read the angle from the defaults. You can instead always read it from the font when needed, you already default to 0 if it is nil.

What do you think? Could simplify things.

[eweracs]

It's a long time since I set this up, but I just checked the xib and that reads the value from that default:

I'm honestly not quite sure how much sense any of this makes, I'll have a proper look at the interface structure again once I am happy with the filter logic. Thanks for pointing this out, in any case.

[Mark2Mark]

I see, if you use it for the binding it is a valid option. It is a little around the corner, and in cases where you really want to store values to the defaults for later use this is the legit way.
Instead of binding it ti the Shared User Defaults and that value, you can bind it to the italic value of the font. But it’s a little tricky to figure out with python and the IB files. I can try to make a sample later. Happy to help, I really like the idea of that plugin and thanks for making it!

[eweracs]

I'm afraid I am very inexperienced with the interface builder, as mentioned I did this a long time ago (the interface hasn't changed in three years). My head is currently in a very different place, occupied with the filter logic, so I probably won't take a lot of time to rethink the interface logic for the time being. Feel free to poke around if you so feel inclined, thanks!

[Mark2Mark]

No worries, it’s not of any urgency. Just wanted to leave it as a note here :)